1466958 - Android 'mach mochitest'/'mach robocop' fails: "IOError: Add-on path does not exist: <objdir>/_tests/testing/mochitest/mochijar"

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Geoff Brown [:gbrown]]

./mach mochitest testing/mochitest/tests/Harness_sanity

 0:22.06 SUITE_START: mochitest-plain - running 25 tests
 0:22.06 TEST_START: testing/mochitest/tests/Harness_sanity/test_TestsRunningAfterSimpleTestFinish.html
 0:22.06 TEST_END: SKIP
 0:22.06 TEST_START: testing/mochitest/tests/Harness_sanity/test_sanityEventUtils.html
 0:22.06 TEST_END: SKIP
 0:22.06 TEST_START: testing/mochitest/tests/Harness_sanity/test_sanity_manifest.html
 0:22.06 TEST_END: SKIP
 0:22.06 TEST_START: testing/mochitest/tests/Harness_sanity/test_sanity_manifest_pf.html
 0:22.06 TEST_END: SKIP
 0:22.06 INFO Running manifest: testing/mochitest/tests/Harness_sanity/mochitest.ini
 0:22.33 ERROR Automation Error: Exception caught while running tests
Traceback (most recent call last):
  File "/home/gbrown/objdirs/x86/_tests/testing/mochitest/runtestsremote.py", line 350, in run_test_harness
    retVal = mochitest.runTests(options)
  File "/home/gbrown/objdirs/x86/_tests/testing/mochitest/runtests.py", line 2608, in runTests
    res = self.runMochitests(options, tests_in_manifest)
  File "/home/gbrown/objdirs/x86/_tests/testing/mochitest/runtests.py", line 2403, in runMochitests
    result = self.doTests(options, testsToRun)
  File "/home/gbrown/objdirs/x86/_tests/testing/mochitest/runtests.py", line 2698, in doTests
    self.manifest = self.buildProfile(options)
  File "/home/gbrown/objdirs/x86/_tests/testing/mochitest/runtestsremote.py", line 228, in buildProfile
    manifest = MochitestDesktop.buildProfile(self, options)
  File "/home/gbrown/objdirs/x86/_tests/testing/mochitest/runtests.py", line 1877, in buildProfile
    whitelistpaths=sandbox_whitelist_paths,
  File "/home/gbrown/src/testing/mozbase/mozprofile/mozprofile/profile.py", line 198, in __init__
    self._reset()
  File "/home/gbrown/src/testing/mozbase/mozprofile/mozprofile/profile.py", line 246, in _reset
    self.addons.install(self._addons)
  File "/home/gbrown/src/testing/mozbase/mozprofile/mozprofile/addons.py", line 201, in install
    self._install_addon(addon, **kwargs)
  File "/home/gbrown/src/testing/mozbase/mozprofile/mozprofile/addons.py", line 128, in _install_addon
    self.addon_details(path)
  File "/home/gbrown/src/testing/mozbase/mozprofile/mozprofile/addons.py", line 251, in addon_details
    raise IOError('Add-on path does not exist: %s' % addon_path)
IOError: Add-on path does not exist: /home/gbrown/objdirs/x86/_tests/testing/mochitest/mochijar
 0:22.66 INFO Buffered messages finished
 0:22.66 SUITE_END


Seems likely this is a regression from changes in bug 1462489.

Comment 1

[Geoff Brown [:gbrown]]

Chris, can you have a look?

Comment 2

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1466958 - hack to make things work

Review commit: https://reviewboard.mozilla.org/r/249440/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/249440/

Comment 3

[Chris Manchester (limited bugmail, email directly)]

The patch from comment 2 makes sense, although looking at it I'd expect that to fail in automation, which it doesn't. I'll upload a version that retains the default for when we're building in automation, but I might need some help verifying the fix.

Comment 4

[Chris Manchester (limited bugmail, email directly)]

Attachment: Bug 1466958 - Fix mochitests when run locally against an android build.

Review commit: https://reviewboard.mozilla.org/r/249842/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/249842/

Comment 5

[Chris Manchester (limited bugmail, email directly)]

:gbrown, does comment 4 work for you? This seems to keep things consistent for local and automation builds.

Comment 6

[James Willcox (:snorp) ([e-mail]) (he/him)]

(In reply to Chris Manchester (:chmanchester) from comment #3)
> The patch from comment 2 makes sense, although looking at it I'd expect that
> to fail in automation, which it doesn't. I'll upload a version that retains
> the default for when we're building in automation, but I might need some
> help verifying the fix.

Ah I think it does fail in automation, actually. I've been wondering why my Try jobs are hosed :)

Comment 7

[James Willcox (:snorp) ([e-mail]) (he/him)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c49cea0fc19dfbc5d87bb8a5c293c72f4b43f0d7&selectedJob=182160413

Comment 8

[Geoff Brown [:gbrown]]

When I run 'mach mochitest testing/mochitest/tests/Harness_sanity' locally, with comment 4 applied, the IOError is avoided, but mochitests do not run: Fennec is launched and loads the mochitest main page, but no tests run.

Comment 9

[Geoff Brown [:gbrown]]

Local runs are okay if I add specialpowers:

diff --git a/testing/mochitest/mochitest_options.py b/testing/mochitest/mochitest_options.py
--- a/testing/mochitest/mochitest_options.py
+++ b/testing/mochitest/mochitest_options.py
@@ -911,16 +911,23 @@ class AndroidArguments(ArgumentContainer
     }
 
     def validate(self, parser, options, context):
         """Validate android options."""
 
         if build_obj:
             options.log_mach = '-'
 
+            objdir_xpi_stage = os.path.join(build_obj.distdir, 'xpi-stage')
+            if os.path.isdir(objdir_xpi_stage):
+                options.extensionsToInstall = [
+                    os.path.join(objdir_xpi_stage, 'specialpowers'),
+                    os.path.join(objdir_xpi_stage, 'mochijar'),
+                ]
+
         if options.remoteWebServer is None:
             if os.name != "nt":
                 options.remoteWebServer = moznetwork.get_ip()
             else:
                 parser.error(
                     "you must specify a --remote-webserver=<ip address>")

Comment 10

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8983981 [details]
Bug 1466958 - Fix mochitests when run locally against an android build.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/249842/diff/1-2/

Comment 11

[Geoff Brown [:gbrown]]

Comment on attachment 8983981 [details]
Bug 1466958 - Fix mochitests when run locally against an android build.

https://reviewboard.mozilla.org/r/249842/#review256360

That should do it. Thanks!

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a68a0a2eff4
Fix mochitests when run locally against an android build. r=gbrown

Comment 13

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/9a68a0a2eff4