Closed Bug 1466968 Opened 2 years ago Closed Last year

[wpt-sync] Sync PR 11360 - Reland "WaveShaper must output non-zero values even if input is silent"

Categories

(Core :: Web Audio, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 11360 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/11360
Details from upstream follow.

Raymond Toy <rtoy@chromium.org> wrote:
>  Reland "WaveShaper must output non-zero values even if input is silent"
>  
>  This is a reland of 325b492fe733ba4c8b2128069a0a232fea1789e3
>  
>  Initialize tail_time_ in constructor so we don't have uninitialized
>  variable.
>  
>  Original change's description:
>  > WaveShaper must output non-zero values even if input is silent
>  >
>  > If the curve for the WaveShaperNode is such that a zero input produces
>  > a non-zero output, the WaveShaperNode needs to output that value even
>  > if the input is silent (or disconnected).
>  >
>  > Do this by setting the tail time of the processor to 0 or infinity
>  > depending on whether the curve specifies an output value of zero or
>  > not, respectively.
>  >
>  > Bug: 807301
>  > Test: WaveShaper/silent-inputs.html
>  > Change-Id: I6539d2e00f5d3e624ffaf2810944eb6d53d6f84b
>  > Reviewed-on: https://chromium-review.googlesource.com/896266
>  > Commit-Queue: Raymond Toy <rtoy@chromium.org>
>  > Reviewed-by: Hongchan Choi <hongchan@chromium.org>
>  > Cr-Commit-Position: refs/heads/master@{#564186}
>  
>  Bug: 807301
>  Change-Id: I866c5b303b40c1245d86daf43c592eed39d6a9c9
>  Reviewed-on: https://chromium-review.googlesource.com/1087427
>  Reviewed-by: Hongchan Choi <hongchan@chromium.org>
>  Commit-Queue: Raymond Toy <rtoy@chromium.org>
>  Cr-Commit-Position: refs/heads/master@{#564630}
>
Component: web-platform-tests → Web Audio
Product: Testing → Core
Ran 1 tests and 11 subtests
OK     : 1
PASS   : 4
FAIL   : 7

New tests that have failures or other problems:
/webaudio/the-audio-api/the-waveshapernode-interface/silent-inputs.html
    # AUDIT TASK RUNNER FINISHED: 3 out of 3 tasks were failed.: FAIL
    < [test-0] 1 out of 1 assertions were failed.: FAIL
    < [test-1] 1 out of 1 assertions were failed.: FAIL
    < [test-2] 1 out of 1 assertions were failed.: FAIL
    X WaveShaper with 2x oversample, silent inputs, and curve {"0":0.5,"1":0.5,"2":0.5}: Expected 0.5 for all values but found 16000 unexpected values: 
	Index	Actual
	[0]	0
	[1]	0
	[2]	0
	[3]	0
	...and 15996 more errors.: FAIL
    X WaveShaper with no inputs and curve {"0":0.5,"1":0.5,"2":0.5}: Expected 0.5 for all values but found 16000 unexpected values: 
	Index	Actual
	[0]	0
	[1]	0
	[2]	0
	[3]	0
	...and 15996 more errors.: FAIL
    X WaveShaper with silent inputs and curve {"0":0.5,"1":0.5,"2":0.5}: Expected 0.5 for all values but found 16000 unexpected values: 
	Index	Actual
	[0]	0
	[1]	0
	[2]	0
	[3]	0
	...and 15996 more errors.: FAIL
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7e0584c3ccea
[wpt PR 11360] - Reland "WaveShaper must output non-zero values even if input is silent", a=testonly
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/mozilla-inbound/rev/346ff23e0802
[wpt PR 11360] - Reland "WaveShaper must output non-zero values even if input is silent", a=testonly
https://hg.mozilla.org/mozilla-central/rev/346ff23e0802
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.