1467008 - Firefox crash with WebRender enabled with specific mozconfig build on Windows

Status: RESOLVED WORKSFORME

(Core :: Graphics: WebRender, defect, P3)

Description

[Sotaro Ikeda [:sotaro]]

When I built Firefox with latest m-c with the following mozconfig, Firefox crashed soon after startup.

ac_add_options --target=x86_64-pc-mingw32
ac_add_options --host=x86_64-pc-mingw32
ac_add_options --enable-profiling

The crash always happened at DisplayListBuilder::pop_clip_id(). The crash hit assert!(!self.clip_stack.is_empty()).

 https://dxr.mozilla.org/mozilla-central/source/gfx/webrender_api/src/display_list.rs#1499


But if I built with the following mozconfig, Firefox did not crash.

ac_add_options --enable-release
ac_add_options --target=x86_64-pc-mingw32
ac_add_options --host=x86_64-pc-mingw32
ac_add_options --enable-profiling

Comment 1

[Sotaro Ikeda [:sotaro]]

I checked comment 0 on 2 win10 machines.

Comment 2

[Sotaro Ikeda [:sotaro]]

Attachment: crash log

Comment 3

[Sotaro Ikeda [:sotaro]]

I checked with visual studio debugger. When mBuilder->PopStackingContext(mReferenceFrameId.isSome()) was called with mReferenceFrameId.isSome() false, rust side pub extern "C" fn wr_dp_pop_stacking_context(state: &mut WrState, is_reference_frame: bool) handled is_reference_frame as true.

From it, the problem seems to be related to a compiler problem.

Comment 4

[Sotaro Ikeda [:sotaro]]

The crash seems to be triggered by Bug 1465058.

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Interesting. We can make PopStackingContext a little more convoluted to try and work around the compiler bug.

Comment 6

[Aria Beingessner [:Gankra]]

same issue as https://bugzilla.mozilla.org/show_bug.cgi?id=1471497#c9 ?

Comment 7

[Kartikaya Gupta (email:[e-mail])]

Pretty sure it was the same issue, fixed now.