1467024 - remove Rooted/PersistentRooted isRootedGCPointerTypeName() special cases already covered by JS_HAZ_ROOTED

Status: RESOLVED FIXED

(Core :: JavaScript: GC, enhancement)

Comment 1

[Karl Tomlinson (:karlt)]

Attachment: bug 1467024 remove Rooted/PersistentRooted special cases already covered by JS_HAZ_ROOTED

Review commit: https://reviewboard.mozilla.org/r/249490/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/249490/

Comment 2

[Karl Tomlinson (:karlt)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=62aa2ffd27f90c992828f44c2a6cb45aa1706cbd

This incidentally also removes RootedBase and RootedListHeads, but it doesn't
look like they needed to be considered rooted:
https://searchfox.org/mozilla-central/rev/292d295d6b084b43b70de26a42e68513bb7b36a3/js/public/RootingAPI.h#124
https://searchfox.org/mozilla-central/rev/292d295d6b084b43b70de26a42e68513bb7b36a3/js/public/RootingAPI.h#835

Comment 3

[Steve Fink [:sfink] [:s:]]

Comment on attachment 8983653 [details]
bug 1467024 remove Rooted/PersistentRooted special cases already covered by JS_HAZ_ROOTED

https://reviewboard.mozilla.org/r/249490/#review255928

Huh. Does this work on the try server? If so, I'm all for it, but I thought that the webidl bindings still needed some work (eg RootedDictionary).

Comment 4

[Karl Tomlinson (:karlt)]

Comment on attachment 8983653 [details]
bug 1467024 remove Rooted/PersistentRooted special cases already covered by JS_HAZ_ROOTED

https://reviewboard.mozilla.org/r/249490/#review255928

It does work on try.  Given NullableRootedDictionary doesn't need a special case in annotations.js, I assume RootedDictionary also doesn't for the same reasons.  I don't know what those reasons are, but I guess they are the same as for other CustomAutoRooter classes.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/49736efeaa34
remove Rooted/PersistentRooted special cases already covered by JS_HAZ_ROOTED r=sfink

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/49736efeaa34