Closed Bug 1467024 Opened 2 years ago Closed 2 years ago

remove Rooted/PersistentRooted isRootedGCPointerTypeName() special cases already covered by JS_HAZ_ROOTED

Categories

(Core :: JavaScript: GC, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox62 --- fixed

People

(Reporter: karlt, Assigned: karlt)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8983653 [details]
bug 1467024 remove Rooted/PersistentRooted special cases already covered by JS_HAZ_ROOTED

https://reviewboard.mozilla.org/r/249490/#review255928

Huh. Does this work on the try server? If so, I'm all for it, but I thought that the webidl bindings still needed some work (eg RootedDictionary).
Attachment #8983653 - Flags: review?(sphink) → review+
Comment on attachment 8983653 [details]
bug 1467024 remove Rooted/PersistentRooted special cases already covered by JS_HAZ_ROOTED

https://reviewboard.mozilla.org/r/249490/#review255928

It does work on try.  Given NullableRootedDictionary doesn't need a special case in annotations.js, I assume RootedDictionary also doesn't for the same reasons.  I don't know what those reasons are, but I guess they are the same as for other CustomAutoRooter classes.
Pushed by ktomlinson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/49736efeaa34
remove Rooted/PersistentRooted special cases already covered by JS_HAZ_ROOTED r=sfink
https://hg.mozilla.org/mozilla-central/rev/49736efeaa34
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.