Closed Bug 1467024 Opened 4 years ago Closed 4 years ago
Rooted is Rooted GCPointer Type Name() special cases already covered by JS _HAZ _ROOTED
59 bytes, text/x-review-board-request
No description provided.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=62aa2ffd27f90c992828f44c2a6cb45aa1706cbd This incidentally also removes RootedBase and RootedListHeads, but it doesn't look like they needed to be considered rooted: https://searchfox.org/mozilla-central/rev/292d295d6b084b43b70de26a42e68513bb7b36a3/js/public/RootingAPI.h#124 https://searchfox.org/mozilla-central/rev/292d295d6b084b43b70de26a42e68513bb7b36a3/js/public/RootingAPI.h#835
Comment on attachment 8983653 [details] bug 1467024 remove Rooted/PersistentRooted special cases already covered by JS_HAZ_ROOTED https://reviewboard.mozilla.org/r/249490/#review255928 Huh. Does this work on the try server? If so, I'm all for it, but I thought that the webidl bindings still needed some work (eg RootedDictionary).
Attachment #8983653 - Flags: review?(sphink) → review+
Comment on attachment 8983653 [details] bug 1467024 remove Rooted/PersistentRooted special cases already covered by JS_HAZ_ROOTED https://reviewboard.mozilla.org/r/249490/#review255928 It does work on try. Given NullableRootedDictionary doesn't need a special case in annotations.js, I assume RootedDictionary also doesn't for the same reasons. I don't know what those reasons are, but I guess they are the same as for other CustomAutoRooter classes.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/49736efeaa34 remove Rooted/PersistentRooted special cases already covered by JS_HAZ_ROOTED r=sfink
You need to log in before you can comment on or make changes to this bug.