1467033 - Add minwidth attribute to toolbox-window.xul and toolbox-process-window.xul

Status: RESOLVED FIXED

(DevTools :: General, enhancement, P3)

Description

[Mantaroh Yoshinaga[:mantaroh]]

+++ This bug was initially created as a clone of Bug #1456056 +++

I landed the patch which defined min-width of devtoools's width. However, the bug 1456056 affect only side bar style. Separated window and browser toolbox can be thin width. (Perhaps 1px)

So we need to define minwidth="50" to this xul. (This 50px is the sum width of chevron button and meatball button. Separated window and browser toolbox doesn't have a close button.)[1][2][3]

[1] https://searchfox.org/mozilla-central/rev/3737701cfab93ccea04c0e9cab211ad10f931d87/devtools/client/framework/toolbox-process-window.xul#12
[2] https://searchfox.org/mozilla-central/rev/3737701cfab93ccea04c0e9cab211ad10f931d87/devtools/client/framework/toolbox-window.xul#12
[3] https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Attribute/minwidth

Comment 1

[Mantaroh Yoshinaga[:mantaroh]]

WIP:https://hg.mozilla.org/try/rev/186f70e294c36eba40ea83b6b3c96b65e847629d

Comment 2

[Mantaroh Yoshinaga[:mantaroh]]

Attachment: Bug 1467033 - Add minwidth=50 to toolbox-window.xul and toolbox-process-window.xul.

This patch will prevent the devtools shrink very narrow width in the case of separated window or browser toolbox.

Review commit: https://reviewboard.mozilla.org/r/249498/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/249498/

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8983663 [details]
Bug 1467033 - Add minwidth=50 to toolbox-window.xul and toolbox-process-window.xul.

https://reviewboard.mozilla.org/r/249498/#review255732

Looks reasonable to me, thanks.

Comment 4

[Mantaroh Yoshinaga[:mantaroh]]

Comment on attachment 8983663 [details]
Bug 1467033 - Add minwidth=50 to toolbox-window.xul and toolbox-process-window.xul.

https://reviewboard.mozilla.org/r/249498/#review255732

Thank you for review!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fbab945ecae7
Add minwidth=50 to toolbox-window.xul and toolbox-process-window.xul. r=jdescottes

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/fbab945ecae7

Comment 7

[Timea Zsoldos [:tzsoldos], Desktop QA]

On Mac OS when the inspector is "Dock to side" and zooming in the inspector window with "CMD +" key, if you resize this window, the close button and Meatball Menu button disappear (on windows, even if you resize the zoomed in window, the close button and the meatball menu button remain in their position and don't disapear).

Comment 8

[Ryan VanderMeulen [:RyanVM]]

Given comment 7, is this something we should consider backporting?

Comment 9

[Brian Birtles (:birtles)]

(In reply to Timea Zsoldos [:zstimi/tzsoldos], Desktop Release QA from comment #7)
> On Mac OS when the inspector is "Dock to side" and zooming in the inspector
> window with "CMD +" key, if you resize this window, the close button and
> Meatball Menu button disappear (on windows, even if you resize the zoomed in
> window, the close button and the meatball menu button remain in their
> position and don't disapear).

Hi Timea, that sounds like a different bug since that's about "Dock to side" and this bug is about the "Separate window" case. Can you please file a separate bug for that? Thanks.

Comment 10

[Timea Zsoldos [:tzsoldos], Desktop QA]

Ok I file a new bug for this: 1468177