Closed Bug 1467033 Opened Last year Closed Last year

Add minwidth attribute to toolbox-window.xul and toolbox-process-window.xul

Categories

(DevTools :: General, enhancement, P3)

enhancement

Tracking

(firefox61 unaffected, firefox62 fixed)

RESOLVED FIXED
Firefox 62
Tracking Status
firefox61 --- unaffected
firefox62 --- fixed

People

(Reporter: mantaroh, Assigned: mantaroh)

References

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1456056 +++

I landed the patch which defined min-width of devtoools's width. However, the bug 1456056 affect only side bar style. Separated window and browser toolbox can be thin width. (Perhaps 1px)

So we need to define minwidth="50" to this xul. (This 50px is the sum width of chevron button and meatball button. Separated window and browser toolbox doesn't have a close button.)[1][2][3]

[1] https://searchfox.org/mozilla-central/rev/3737701cfab93ccea04c0e9cab211ad10f931d87/devtools/client/framework/toolbox-process-window.xul#12
[2] https://searchfox.org/mozilla-central/rev/3737701cfab93ccea04c0e9cab211ad10f931d87/devtools/client/framework/toolbox-window.xul#12
[3] https://developer.mozilla.org/en-US/docs/Mozilla/Tech/XUL/Attribute/minwidth
Assignee: nobody → mantaroh
Comment on attachment 8983663 [details]
Bug 1467033 - Add minwidth=50 to toolbox-window.xul and toolbox-process-window.xul.

https://reviewboard.mozilla.org/r/249498/#review255732

Looks reasonable to me, thanks.
Attachment #8983663 - Flags: review?(jdescottes) → review+
Comment on attachment 8983663 [details]
Bug 1467033 - Add minwidth=50 to toolbox-window.xul and toolbox-process-window.xul.

https://reviewboard.mozilla.org/r/249498/#review255732

Thank you for review!
Pushed by mantaroh@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/fbab945ecae7
Add minwidth=50 to toolbox-window.xul and toolbox-process-window.xul. r=jdescottes
https://hg.mozilla.org/mozilla-central/rev/fbab945ecae7
Status: NEW → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
On Mac OS when the inspector is "Dock to side" and zooming in the inspector window with "CMD +" key, if you resize this window, the close button and Meatball Menu button disappear (on windows, even if you resize the zoomed in window, the close button and the meatball menu button remain in their position and don't disapear).
Given comment 7, is this something we should consider backporting?
Flags: needinfo?(mantaroh)
(In reply to Timea Zsoldos [:zstimi/tzsoldos], Desktop Release QA from comment #7)
> On Mac OS when the inspector is "Dock to side" and zooming in the inspector
> window with "CMD +" key, if you resize this window, the close button and
> Meatball Menu button disappear (on windows, even if you resize the zoomed in
> window, the close button and the meatball menu button remain in their
> position and don't disapear).

Hi Timea, that sounds like a different bug since that's about "Dock to side" and this bug is about the "Separate window" case. Can you please file a separate bug for that? Thanks.
Flags: needinfo?(mantaroh) → needinfo?(timea.zsoldos)
Ok I file a new bug for this: 1468177
Flags: needinfo?(timea.zsoldos)
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.