Closed
Bug 1467138
Opened 7 years ago
Closed 7 years ago
Disabled extensions are re-enabled after a refresh of the web page
Categories
(Firefox for Android Graveyard :: Add-on Manager, defect)
Tracking
(firefox60 unaffected, firefox61 unaffected, firefox62 verified)
VERIFIED
FIXED
Firefox 62
Tracking | Status | |
---|---|---|
firefox60 | --- | unaffected |
firefox61 | --- | unaffected |
firefox62 | --- | verified |
People
(Reporter: cbadescu, Assigned: rpl)
Details
(Keywords: regression)
Attachments
(2 files)
[Affected versions]:
- Firefox 62.0a1 (2018-06-06)
[Affected platforms]:
- Android 6.0.1
- Android 7.0
[Steps to reproduce]:
1.Install some extensions and themes.
2.Go at about:addons page.
3.Disable some extensions and themes.
4.Refresh the web page.
[Expected results]:
- The extensions and themes remain disabled.
[Actual results]:
- The extensions and themes are re-enabled.
Please see the attached video
Comment hidden (mozreview-request) |
Assignee | ||
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8983899 [details]
Bug 1467138 - Fix disable/enable extensions from Fennec about:addons page.
https://reviewboard.mozilla.org/r/249746/#review255948
::: mobile/android/chrome/content/aboutAddons.js:522
(Diff revision 1)
> function setDisabled(addon, value) {
> if (value) {
> - return addon.enable();
> - }
> - return addon.disable();
> + return addon.disable();
> - }
> + }
> + return addon.enable();
> + }
Like mentioned in the commit message, this `setDisabled` helper function has been introduced by Bug 1461146, but unfortunately we didn't notice that it is currently calling `addon.enable()` when `value` is `true` and `addon.disable()` otherwise, but it should be actually doing the opposite (the function is called `setDisabled` and so `true` means that we should call `addon.disable()`).
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → lgreco
Status: NEW → ASSIGNED
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8983899 [details]
Bug 1467138 - Fix disable/enable extensions from Fennec about:addons page.
https://reviewboard.mozilla.org/r/249746/#review255990
Attachment #8983899 -
Flags: review?(aswan) → review+
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/4f885a43b217
Fix disable/enable extensions from Fennec about:addons page. r=aswan
Comment 5•7 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Comment 6•7 years ago
|
||
Environment:
Samsung Galaxy Tab S3 (Android 7) - 62.0b3
Extensions and themes are no longer enabled when refreshing the page. Marking this as verified.
Status: RESOLVED → VERIFIED
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•