1467138 - Disabled extensions are re-enabled after a refresh of the web page

Status: VERIFIED FIXED

Description

[CosminB]

Attachment: DisabledEnabled.gif

[Affected versions]:
- Firefox 62.0a1 (2018-06-06)

[Affected platforms]:
- Android 6.0.1
- Android 7.0

[Steps to reproduce]:
1.Install some extensions and themes.
2.Go at about:addons page.
3.Disable some extensions and themes.
4.Refresh the web page.

[Expected results]:
- The extensions and themes remain disabled.

[Actual results]:
- The extensions and themes are re-enabled.

Please see the attached video

Comment 1

[Luca Greco [:rpl] [:luca]]

Attachment: Bug 1467138 - Fix disable/enable extensions from Fennec about:addons page.

This patch fixes a regression introduced by Bug 1461146 ("Replace Addon.userDisabled setter
with async enable()/disable() methods").

Review commit: https://reviewboard.mozilla.org/r/249746/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/249746/

Comment 2

[Luca Greco [:rpl] [:luca]]

Comment on attachment 8983899 [details]
Bug 1467138 - Fix disable/enable extensions from Fennec about:addons page.

https://reviewboard.mozilla.org/r/249746/#review255948

::: mobile/android/chrome/content/aboutAddons.js:522
(Diff revision 1)
>      function setDisabled(addon, value) {
>        if (value) {
> -        return addon.enable();
> -      }
> -      return addon.disable();
> +        return addon.disable();
> -    }
> +      }
> +      return addon.enable();
> +    }

Like mentioned in the commit message, this `setDisabled` helper function has been introduced by Bug 1461146, but unfortunately we didn't notice that it is currently calling `addon.enable()` when `value` is `true` and `addon.disable()` otherwise, but it should be actually doing the opposite (the function is called `setDisabled` and so `true` means that we should call `addon.disable()`).

Comment 3

[Andrew Swan [:aswan]]

Comment on attachment 8983899 [details]
Bug 1467138 - Fix disable/enable extensions from Fennec about:addons page.

https://reviewboard.mozilla.org/r/249746/#review255990

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f885a43b217
Fix disable/enable extensions from Fennec about:addons page. r=aswan

Comment 5

[Andrei Ciure[:andrei_ciure]]

https://hg.mozilla.org/mozilla-central/rev/4f885a43b217

Comment 6

[Bogdan Surd, QA [:bsurd, NI]]

Environment:
Samsung Galaxy Tab S3 (Android 7) - 62.0b3

Extensions and themes are no longer enabled when refreshing the page. Marking this as verified.