Open Bug 1467156 Opened 7 years ago Updated 3 years ago

[developer] Code safety: Remove force unwrapped member vars in BrowserViewController

Categories

(Firefox for iOS :: General, enhancement, P3)

Product:
Firefox for iOS
Component:
General
Platform:
Other
iOS
Type:
enhancement

Tracking

()

Tracking Flags:
Tracking Status
fxios + ---

People

(Reporter: garvan, Unassigned)

Details

BrowserViewController uses the UI-code convention of unwrapped optional member vars that are instantiated in viewDidLoad(). This class has grown in complexity such that it may get called accidentally before viewDidLoad() in future. Reviewing the code, my impression is that all of these optionals can be instantiated at init time without too much difficulty.
tracking-fxios: ? → +
Priority: -- → P3
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.