1467159 - Graphs Add Test Data gets stuck at "Loading series data..." until window resized

Status: RESOLVED FIXED

(Tree Management :: Perfherder, enhancement, P1)

Description

[Kartikaya Gupta (email:[e-mail])]

Go to https://treeherder.mozilla.org/perf.html#/graphs and click the Add Test data button.

Expected: list of tests shows up quickly
Actual: "Loading series data..." blinking text is displayed for a long time.

Even better, if you resize the browser window, the series data is rendered right away.

Comment 1

[Ed Morley [:emorley]]

Hi! Thank you for filing.

Bisecting locally this appears to have started as of bug 1450039. I presume one of the switches from AngularJS' $http to fetch() means an `$apply()` or similar is now needed to force a digest cycle. (This is due to our mixing and matching of AngularJS and React as part of the transition to using only React.)

Comment 2

[Cameron Dawson [:camd]]

Ahh, I'm sure Ed is correct here.  That sounds like exactly what it is.  I'll take a look shortly to get a fix in.

Comment 3

[Cameron Dawson [:camd]]

I'll see if I can fix this tomorrow.

Comment 4

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3639

Comment 5

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/af05c091f6c1ea18101935c34b6f5dc5b4179a8a
Bug 1467159 - Fix Graphs Add Test Data geting stuck (#3639)