1467232 - Toggling the 'Show subsession data' checkbox duplicates the text on about:telemetry

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Jared Wein [:jaws] (please needinfo? me)]

STR:
1. go to about:telemetry
2. click on the 'current ping v' dropdown in the top left
3. toggle the 'Show subsession data' checkbox on and off multiple times

ER:
Some categories should hide/show relative to the checkbox state

AR:
The categories hide/show, but the text "Each piece of information is sent bundled into “pings“. You are looking at the current ping." gets duplicated with each click on the checkbox.

Comment 1

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1467232 - Clear the explanation text first, before adding any changed text.

Review commit: https://reviewboard.mozilla.org/r/249940/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/249940/

Comment 2

[Jan-Erik Rediger [:janerik]]

Attachment: Bug 1467232 - Ensure ping explanation is formatted correctly.

The "pingDetails" explanation takes only 2 arguments: a link and the name of the ping to be displayed.

Review commit: https://reviewboard.mozilla.org/r/249942/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/249942/

Comment 3

[Alessio Placitelli [:Dexter]]

Comment on attachment 8984100 [details]
Bug 1467232 - Clear the explanation text first, before adding any changed text.

https://reviewboard.mozilla.org/r/249940/#review256188

This looks sane to me.

Comment 4

[Alessio Placitelli [:Dexter]]

Comment on attachment 8984101 [details]
Bug 1467232 - Ensure ping explanation is formatted correctly.

https://reviewboard.mozilla.org/r/249942/#review256192

Good catch!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/659052b94cab
Clear the explanation text first, before adding any changed text. r=Dexter
https://hg.mozilla.org/integration/autoland/rev/0943910146c4
Ensure ping explanation is formatted correctly. r=Dexter

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/659052b94cab
https://hg.mozilla.org/mozilla-central/rev/0943910146c4