Closed Bug 1467232 Opened 5 years ago Closed 5 years ago

Toggling the 'Show subsession data' checkbox duplicates the text on about:telemetry

Categories

(Toolkit :: Telemetry, defect, P1)

Product:
Toolkit
Component:
Telemetry
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: jaws, Assigned: janerik)

Details

Attachments

(2 files)

Bug 1467232 - Clear the explanation text first, before adding any changed text.
59 bytes, text/x-review-board-request
Dexter
: review+
Details
Bug 1467232 - Ensure ping explanation is formatted correctly.
59 bytes, text/x-review-board-request
Dexter
: review+
Details 
STR:
1. go to about:telemetry
2. click on the 'current ping v' dropdown in the top left
3. toggle the 'Show subsession data' checkbox on and off multiple times

ER:
Some categories should hide/show relative to the checkbox state

AR:
The categories hide/show, but the text "Each piece of information is sent bundled into “pings“. You are looking at the current ping." gets duplicated with each click on the checkbox.
Assignee: nobody → jrediger
Priority: -- → P1
Comment on attachment 8984100 [details]
Bug 1467232 - Clear the explanation text first, before adding any changed text.

https://reviewboard.mozilla.org/r/249940/#review256188

This looks sane to me.
Attachment #8984100 - Flags: review?(alessio.placitelli) → review+
Comment on attachment 8984101 [details]
Bug 1467232 - Ensure ping explanation is formatted correctly.

https://reviewboard.mozilla.org/r/249942/#review256192

Good catch!
Attachment #8984101 - Flags: review?(alessio.placitelli) → review+
Pushed by jrediger@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/659052b94cab
Clear the explanation text first, before adding any changed text. r=Dexter
https://hg.mozilla.org/integration/autoland/rev/0943910146c4
Ensure ping explanation is formatted correctly. r=Dexter
https://hg.mozilla.org/mozilla-central/rev/659052b94cab
https://hg.mozilla.org/mozilla-central/rev/0943910146c4
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.