1467270 - Convert lodash .every() to native ES6 JS

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P3)

Description

[Eliott Vincent [:evct] (GMT+2)]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.170 Safari/537.36 OPR/53.0.2907.68

Steps to reproduce:

Converting all _.every() (lodash) functions to native .every() (ES6 JS)

Comment 1

[Eliott Vincent [:evct] (GMT+2)]

I finished working on it, but I'm having a problem to push my changes.

I created a local branch to work on but when I want to push it to the remote I obtain the following error message: "Access denied. Make sure you have access to do that action on that remote and try again. If mozilla is an organization on GitHub, you may need to request or grant access to the organization for GitKraken".

What's the workaround?

Comment 2

[Ed Morley [:emorley]]

Hi! Thank you for working on this!

It sounds like GitKraken is trying to push to the upstream Treeherder repo, rather than your fork of it. I'd check your fork has been created:
https://help.github.com/articles/fork-a-repo/

...and then making sure GitKraken is using it:
https://support.gitkraken.com/working-with-repositories/pushing-and-pulling
https://blog.axosoft.com/how-to-manage-git-workflow-forks/

Let us know how you get on :-)

Comment 3

[Eliott Vincent [:evct] (GMT+2)]

Ok thanks for your fast answer, in fact I didn't fork the Treeherder, I just cloned it.
That's why GitKraken tries to push to the upstream repo.
No ways to work from the clone of the repo instead of having to fork it?

Comment 4

[Eliott Vincent [:evct] (GMT+2)]

Ignore my last question, I will work by forking the repo.

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3625

Comment 6

[Eliott Vincent [:evct] (GMT+2)]

It seems that I can't add someone to review this due to permissions..
Can someone review this please?

Comment 7

[Ed Morley [:emorley]]

Comment on attachment 8984042 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3625

Certainly :-)

Comment 8

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/ac810b155eca696cc8689a4af06f7b50b545065a
Bug 1467270 - convert _.every() usages to ES6 (#3625)