1467332 - Change the wpt-manifest upload format

Status: RESOLVED FIXED

(Testing :: web-platform-tests, enhancement)

Description

[Ahilya Sinha [:cactusmachete]]

Upload both manifests in a single tar, not two different gzipped files.

Comment 1

[Ahilya Sinha [:cactusmachete]]

Attachment: Bug 1467332 - Change wpt-manifest upload format,

Review commit: https://reviewboard.mozilla.org/r/249878/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/249878/

Comment 2

[James Graham [:jgraham]]

Comment on attachment 8983998 [details]
Bug 1467332 - Change wpt-manifest upload format,

https://reviewboard.mozilla.org/r/249878/#review256156

This basically looks fine, just a couple of nits to fix.

::: taskcluster/ci/source-test/wpt-manifest.yml:24
(Diff revision 1)
>      run:
>          using: run-task
>          command: >
>              cd /builds/worker/checkouts/gecko
>              && ./mach wpt-manifest-update
> -            && gzip testing/web-platform/meta/MANIFEST.json testing/web-platform/mozilla/meta/MANIFEST.json
> +            && tar -cvzf manifests.tar.gz -C testing/web-platform/ meta/MANIFEST.json mozilla/meta/MANIFEST.json

I would just pull full paths rather than using a stateful option; we'll probably need to change these paths later on anyway.

::: testing/web-platform/manifestdownload.py:84
(Diff revision 1)
> -    if resp.code != 200:
> +    if req.status_code != 200:
>          logger.warning("Downloading pregenerated manifest failed; got"
> -                        "HTTP status %d" % resp.code)
> +                        "HTTP status %d" % req.status_code)
>          return False
>  
> -    gzf = gzip.GzipFile(fileobj=io.BytesIO(resp.read()))
> +    tar = tarfile.open(mode="r:gz",fileobj=StringIO(req.content))

Missing a space after the comma

Comment 3

[Ahilya Sinha [:cactusmachete]]

Comment on attachment 8983998 [details]
Bug 1467332 - Change wpt-manifest upload format,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/249878/diff/1-2/

Comment 4

[James Graham [:jgraham]]

Comment on attachment 8983998 [details]
Bug 1467332 - Change wpt-manifest upload format,

https://reviewboard.mozilla.org/r/249878/#review256300

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1cd94ab77e2e
Change wpt-manifest upload format, r=jgraham

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/1cd94ab77e2e