Closed
Bug 1467350
Opened 7 years ago
Closed 7 years ago
HTMLMediaElement::mPaused can be state watched instead of manually updated
Categories
(Core :: Audio/Video: Playback, enhancement, P2)
Core
Audio/Video: Playback
Tracking
()
RESOLVED
FIXED
mozilla62
Tracking | Status | |
---|---|---|
firefox62 | --- | fixed |
People
(Reporter: cpearce, Assigned: cpearce)
Details
Attachments
(1 file)
We currently have a custom WakeLockBoolWrapper wrapping HTMLMediaElement::mPaused. This is basically the same as mozilla::Watchable<bool>, except it's hand-rolled. We can make this Watchable<> instead, and reduce custom code.
Assignee | ||
Updated•7 years ago
|
Summary: HTMLMediaElement::mPaused cana be state watched instead of manually updated → HTMLMediaElement::mPaused can be state watched instead of manually updated
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8984015 [details]
Bug 1467350 - Make HTMLMediaElement::mPaused Watchable and update Wakelock status via a watcher.
https://reviewboard.mozilla.org/r/249888/#review256162
Attachment #8984015 -
Flags: review?(jyavenard) → review+
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/765bb540a814
Make HTMLMediaElement::mPaused Watchable and update Wakelock status via a watcher. r=jya
Comment 4•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox62:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in
before you can comment on or make changes to this bug.
Description
•