1467350 - HTMLMediaElement::mPaused can be state watched instead of manually updated

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement, P2)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

We currently have a custom WakeLockBoolWrapper wrapping HTMLMediaElement::mPaused. This is basically the same as mozilla::Watchable<bool>, except it's hand-rolled. We can make this Watchable<> instead, and reduce custom code.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1467350 - Make HTMLMediaElement::mPaused Watchable and update Wakelock status via a watcher.

We currently observe changes to HTMLMediaElement::mPaused via a hand-rolled
wrapper class. We can use use mozilla::Watchable<> and avoid rolling our
own equivalent here.

This also paves the way for using state watching on other observable state
in HTMLMediaElement.

Review commit: https://reviewboard.mozilla.org/r/249888/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/249888/

Comment 2

[Jean-Yves Avenard [:jya]]

Comment on attachment 8984015 [details]
Bug 1467350 - Make HTMLMediaElement::mPaused Watchable and update Wakelock status via a watcher.

https://reviewboard.mozilla.org/r/249888/#review256162

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/765bb540a814
Make HTMLMediaElement::mPaused Watchable and update Wakelock status via a watcher. r=jya

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/765bb540a814