Closed Bug 1467350 Opened Last year Closed Last year

HTMLMediaElement::mPaused can be state watched instead of manually updated

Categories

(Core :: Audio/Video: Playback, enhancement, P2)

Product:
Core
Component:
Audio/Video: Playback
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla62
Tracking Flags:
Tracking Status
firefox62 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

Details

Attachments

(1 file)

Bug 1467350 - Make HTMLMediaElement::mPaused Watchable and update Wakelock status via a watcher.
59 bytes, text/x-review-board-request
jya
: review+
Details 
We currently have a custom WakeLockBoolWrapper wrapping HTMLMediaElement::mPaused. This is basically the same as mozilla::Watchable<bool>, except it's hand-rolled. We can make this Watchable<> instead, and reduce custom code.
Summary: HTMLMediaElement::mPaused cana be state watched instead of manually updated → HTMLMediaElement::mPaused can be state watched instead of manually updated
Comment on attachment 8984015 [details]
Bug 1467350 - Make HTMLMediaElement::mPaused Watchable and update Wakelock status via a watcher.

https://reviewboard.mozilla.org/r/249888/#review256162
Attachment #8984015 - Flags: review?(jyavenard) → review+
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/765bb540a814
Make HTMLMediaElement::mPaused Watchable and update Wakelock status via a watcher. r=jya
https://hg.mozilla.org/mozilla-central/rev/765bb540a814
Status: NEW → RESOLVED
Closed: Last year
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
You need to log in before you can comment on or make changes to this bug.