Closed Bug 1467373 Opened 3 years ago Closed 3 years ago

[TSF][TS_E_NOLAYOUT] Separate TS_E_NOLAYOUT hacks in TSFTextStore::GetTextExt() into new methods and disable these hacks on Win10 Build 17643 or newer

Categories

(Core :: Widget: Win32, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox62 --- wontfix
firefox63 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

(Keywords: inputmethod)

Attachments

(2 files)

Now, we have a lot of hacks of TS_E_NOLAYOUT bug of Windows:
https://searchfox.org/mozilla-central/rev/cf464eabfeba64e866c1fa36b9fefd674dca9c51/widget/windows/TSFTextStore.cpp#4428-4625

These hacks are ugly and makes difficult to check entire code in GetTextExt(). So, let's move those hacks into new methods, and then, stop running almost all of these hacks on Win10 Build 17643 or later since the bug of Windows has been fixed!

See also my blog post: https://d-toybox.com/studio/weblog/show.php?id=2018060200

FYI: Stopping running the hacks will make some IME behavior better.
Status: NEW → ASSIGNED
Comment on attachment 8996972 [details]
Bug 1467373 - part 1: Split hack for TS_E_NOLAYOUT part from TSFTextStore::GetTextExt()

https://reviewboard.mozilla.org/r/260948/#review268206
Attachment #8996972 - Flags: review?(m_kato) → review+
Comment on attachment 8996973 [details]
Bug 1467373 - part 2: Skip hacks for most TIPs in TSFTextStore::HackNoErrorLayoutBugs() if running on Windows 10 build 17643 or newer

https://reviewboard.mozilla.org/r/260950/#review268210
Attachment #8996973 - Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/79e964194d99
part 1: Split hack for TS_E_NOLAYOUT part from TSFTextStore::GetTextExt() r=m_kato
https://hg.mozilla.org/integration/autoland/rev/845a7347f1a9
part 2: Skip hacks for most TIPs in TSFTextStore::HackNoErrorLayoutBugs() if running on Windows 10 build 17643 or newer r=m_kato
https://hg.mozilla.org/mozilla-central/rev/79e964194d99
https://hg.mozilla.org/mozilla-central/rev/845a7347f1a9
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
Summary: [TSF] Separate TS_E_NOLAYOUT hacks in TSFTextStore::GetTextExt() into new methods and disable these hacks on Win10 Build 17643 or newer → [TSF][TS_E_NOLAYOUT] Separate TS_E_NOLAYOUT hacks in TSFTextStore::GetTextExt() into new methods and disable these hacks on Win10 Build 17643 or newer
You need to log in before you can comment on or make changes to this bug.