Keyboard shortcut empty for element with accesskey

RESOLVED FIXED in Firefox 62

Status

defect
RESOLVED FIXED
11 months ago
10 months ago

People

(Reporter: Jamie, Assigned: yzen)

Tracking

({dev-doc-complete})

Trunk
Firefox 62

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 months ago
STR:
1. Open this URL:
data:text/html,<a href="foo" accesskey="f">foo</a>
2. Right click the link and select "Inspect Accessibility Properties".
3. Look at the keyboardShortcut property.
Actual: ""
Expected: "alt+shift+f" (or similar)

I think this occurs because Gecko a11y exposes two key bindings: Accessible::AccessKey and Accessible::KeyboardShortcut. The former is used for accesskey, where the latter is used for global shortcuts defined by XUL menu items, etc. IMO, for the purposes of the inspector's keyboardShortcut property, we should do what the Windows implementation does: try AccessKey first, and if that's empty, use KeyboardShortcut.

Updated

10 months ago
Product: Firefox → DevTools
(Assignee)

Comment 1

10 months ago
Posted patch 1467381 patchSplinter Review
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Attachment #8985422 - Flags: review?(pbrosset)
Attachment #8985422 - Flags: review?(pbrosset) → review+

Comment 2

10 months ago
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/45a968a577b7
check Accessible::AccessKey and Accessible::KeyboardShortcut when filling up keyboardShortcut for accessible actor. r=pbro

Comment 3

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/45a968a577b7
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
You need to log in before you can comment on or make changes to this bug.