1467381 - Keyboard shortcut empty for element with accesskey

Status: RESOLVED FIXED

(DevTools :: Accessibility Tools, defect)

Description

[James Teh [:Jamie]]

STR:
1. Open this URL:
data:text/html,<a href="foo" accesskey="f">foo</a>
2. Right click the link and select "Inspect Accessibility Properties".
3. Look at the keyboardShortcut property.
Actual: ""
Expected: "alt+shift+f" (or similar)

I think this occurs because Gecko a11y exposes two key bindings: Accessible::AccessKey and Accessible::KeyboardShortcut. The former is used for accesskey, where the latter is used for global shortcuts defined by XUL menu items, etc. IMO, for the purposes of the inspector's keyboardShortcut property, we should do what the Windows implementation does: try AccessKey first, and if that's empty, use KeyboardShortcut.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: 1467381 patch

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/45a968a577b7
check Accessible::AccessKey and Accessible::KeyboardShortcut when filling up keyboardShortcut for accessible actor. r=pbro

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/45a968a577b7