1467403 - Stop handling source notes in prologue

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P3)

Description

[Tooru Fujisawa [:arai]]

I cannot find any case that prologue contains source notes.
we could remove code which handles it.

Comment 1

[Tooru Fujisawa [:arai]]

it's always empty.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=f73c011efe69f74cf15169e8d3966587a911a5bf

Comment 2

[Tooru Fujisawa [:arai]]

Attachment: Remove the source notes handling for prologue bytecode.

mostly just removed the code that handles when prologue have source notes.
BytecodeEmitter::finishTakingSrcNotes's else-clause is necessary since the delta of the source note in the main section has to be updated to reflect the prologue bytecode length.

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 8984332 [details] [diff] [review]
Remove the source notes handling for prologue bytecode.

Review of attachment 8984332 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

::: js/src/frontend/BytecodeEmitter.cpp
@@ +11458,5 @@
>      MOZ_ASSERT(current == &main);
>  
> +    MOZ_ASSERT(prologue.notes.length() == 0);
> +    MOZ_ASSERT(prologue.lastNoteOffset == 0);
> +    // We may need to adjust the offset of the first main note, by adding to

Nit: we usually have a blank line before comments like this, if not at the start of a block?

Comment 4

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/09d892dcaca7f8700a08f14b3b075b769bd82c5d
Bug 1467403 - Remove the source notes handling for prologue bytecode. r=jandem

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/09d892dcaca7