1467428 - firefoxtree broken (No module named grp)

Status: RESOLVED FIXED

(Developer Services :: Mercurial: firefoxtree, enhancement)

Description

[Ryan VanderMeulen [:RyanVM]]

Reproducible on Windows with hg 4.5.3 and 4.6. Looks like grp is Unix-only?
https://docs.python.org/2.0/lib/module-grp.html

$ hg pull central
*** failed to import extension firefoxtree from c:\Users\Ryan\.mozbuild\version-control-tools\hgext\firefoxtree: No module named grp
pulling from central
abort: repository central not found!

Comment 1

[(No longer employed by Mozilla) Aaron Klotz]

It looks like this also affects other mercurial extensions in version-control-tools; In addition to firefoxtree, I also can no longer import the reviewboard or bzpost extensions.

Comment 2

[Phabricator Automation]

Attachment: mozhg: defer import of grp module (bug 1467428); r?sheehan

Or things fail on Windows because this module is imported by
various user-facing extensions.

Comment 3

[Phabricator Automation]

Comment on attachment 8984249 [details]
mozhg: defer import of grp module (bug 1467428); r?sheehan

Ryan VanderMeulen [:RyanVM] has approved the revision.

https://phabricator.services.mozilla.com/D1584

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/hgcustom/version-control-tools/rev/47a5900d285b
mozhg: defer import of grp module ; r=RyanVM

Comment 5

[Gregory Szorc [:gps]]

Forgot to close the needinfo.