1467435 - Convert lodash .map() to native ES6 JS

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P3)

Description

[Eliott Vincent [:evct] (GMT+2)]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.170 Safari/537.36 OPR/53.0.2907.68

Steps to reproduce:

Converting all _.map() (lodash) functions to native .map() (ES6 JS)

Comment 1

[Eliott Vincent [:evct] (GMT+2)]

I will need some time to work on this since _.map() is used more than 60 times in the code.

Comment 2

[Eliott Vincent [:evct] (GMT+2)]

Just for memo:

Lodash: _.map(array, iteratee);
ES6: array.map(iteratee);

Most of the time, iteratee is a method to transform the keys.
But Lodash provides a shorthand to directly pass a property name as iteratee (under the hood, it uses _.property()).

Each time we need to convert this shorthand to ES6, we will need to create an anonymous function returning the property we want.

Comment 3

[Eliott Vincent [:evct] (GMT+2)]

Proposed solution:
Lodash: _.map(seriesToMeasure, 'platform')
ES6: seriesToMeasure.map(serie => serie.platform)

Comment 4

[Eliott Vincent [:evct] (GMT+2)]

Ok I found that some calls of _.map() are done on Objects.
However the ES6 native .map() method is an Array method. I will skip those cases.

Comment 5

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3632

Comment 6

[Cameron Dawson [:camd]]

Asked for updates in the PR.

Comment 7

[Cameron Dawson [:camd]]

Comment on attachment 8984182 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3632

Clearing review till updates come in.  But need-info'ing myself to keep it on my radar.  :)

Comment 8

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/68d635fabb18e5d9bb46bd67edbf023624f6b277
Bug 1467435 - convert _.map() usages to ES6 (#3632)