1467437 - hashchange and popstate events should not bubble

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Philip Jägenstedt [:foolip]]

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.62 Safari/537.36

Steps to reproduce:

Tests: https://github.com/web-platform-tests/wpt/pull/11355
Gecko import: https://bugzilla.mozilla.org/show_bug.cgi?id=1466827
Spec change: https://github.com/whatwg/html/pull/3737

Results will be available here:
https://wpt.fyi/results/html/browsers/browsing-the-web/history-traversal/hashchange_event.html
https://wpt.fyi/results/html/browsers/browsing-the-web/history-traversal/popstate_event.html


Actual results:

Only fires has event.bubbling set to true for the hashchange and popstate events. Since it fires on the window object, there isn't anywhere to bubble up to, so it'll only affect the event's bubbling property.


Expected results:

These two events should not bubble, per recent spec change.

Comment 1

[Boris Zbarsky [:bzbarsky]]

Attachment: Bug 1467437. Align with other browsers and the spec for whether hashchange and popstate events bubble.

I think I caught all the places in our tree that add event listeners for these
events on a non-Window (and hence depend on bubbling behavior), but I'm a
little worried about what happens if webextensions do bareword
addEventListener() for these events...

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c4c3a54fcffa
Align with other browsers and the spec for whether hashchange and popstate events bubble. r=smaug

Comment 3

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/c4c3a54fcffa