1467448 - [10.14] Session restore not working consistently

Status: RESOLVED WORKSFORME

(Firefox :: Session Restore, defect, P3)

Description

[Marcia Knous [:marcia]]

Seen while running Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:62.0) Gecko/20100101 Firefox/62.0. Running the Mojave 10.14 beta.

STR:
1. Either sleep the machine or shut down the browser.
2. After signing back in and launching Nightly, I get the screen saying it cannot restore my session. I have been seeing this pretty consistently since I started running the 10.14 beta.

I will check to see whether it happens with Beta and Release as well on this machine.

Comment 1

[Mike Taylor [:miketaylr]]

I guess Mojave is slated for release in Fall, which is roughly when 62 will also be released.

Comment 2

[Stephen A Pohl [:spohl]]

I haven't been able to reproduce this bug so far, but this is using a clean install of 10.13, which was then upgraded to 10.14 right away. It would be great to know if this reproduces with a new profile and/or beta and release.

Comment 3

[Liz Henry (:lizzard) (relman/hg->git project)]

Tracking for 62 since this is rated P1 and the projected release date for 10.14 is in September or October this year. 

Camelia - can you or Gabi try to reproduce the issue? Thanks!

Comment 4

[Justin Dolske [:Dolske]]

This needs QA to have a reproducible test case before this is actionable.

Comment 5

[Mike Conley (:mconley) (:⚙️)]

If it helps, when we fail to flush the session to disk, this is sometimes because we crashed. If you're still seeing this, do you see an associated crash report in about:crashes?

Comment 6

[Marcia Knous [:marcia]]

(In reply to Mike Conley (:mconley) (:⚙️) (PTO Jul 24th-Aug 6th)) from comment #5)
> If it helps, when we fail to flush the session to disk, this is sometimes
> because we crashed. If you're still seeing this, do you see an associated
> crash report in about:crashes?

No, I never saw any crashes generated as a result of this. Also note that this bug was filed a month ago - there is now a much newer beta available that QA should be able to test with. I will continue to see if I can find a set of STR for this as well.

Comment 7

[Camelia Badau [:cbadau], Desktop Test Engineering]

We tested on macOS 10.14 Beta 3 build using Firefox 62 Beta 10 and we can't reproduce the issue. We tried the following scenarios: 
- crash Firefox, restart - in this case, the Restore Session page is correctly displayed (with "Restore Session" and "Start new session" options)
- "sleep the machine -> launch Firefox" or "quit Firefox -> reopen it" - 2 situations here: 
                                         - "Restore previous session" option is UNCHECKED in about:preferences page -> the New Tab page is displayed; we can restore session from "Restore previous session" option from Hamburger Menu or History -> Tab Menu
                                         - "Restore previous session" option is CHECKED in about:preferences page -> all the tabs/windows are restored

Do we missed something in these scenarios?

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

It sounds like this may be fixed with the new 10.14 beta.

Comment 9

[Marcia Knous [:marcia]]

In my case, I have the pref on to Restore Previous Session. The first time I crashed, all of my tabs are restored. The second time I crashed (and every subequent time) I always get the Session Restore page which give me the option to restore. And sometimes when I chose to "Restore Session" I did not get my tabs back. I think I only had 3-4 tabs open, one with Gmail and some other Bugzilla bugs loaded. But in all of my cases, I was crashing and then trying to session restore, not sleeping the machine or quitting normally.

I am also testing with Nightly on 10.14, not beta.

Comment 10

[Liz Henry (:lizzard) (relman/hg->git project)]

Camelia, can you try with nightly?

Comment 11

[Camelia Badau [:cbadau], Desktop Test Engineering]

We retested on macOS 10.14 Beta 4 build (18A336e) using latest Nightly 63.0a1 (2018-07-26), but we can't reproduce the issue: we crashed Firefox several times (15/20/25 times) with pref "on" for Restore Previous Session -> we always get the Session Restore page with "Restore Session" option (except the first time we crashed) -> every time when we chose to "Restore Session", all the tabs were correctly restored.

Comment 12

[Justin Dolske [:Dolske]]

(In reply to Marcia Knous [:marcia - needinfo? me] from comment #9)
> In my case, I have the pref on to Restore Previous Session. The first time I
> crashed, all of my tabs are restored. The second time I crashed (and every
> subequent time) I always get the Session Restore page which give me the
> option to restore. And sometimes when I chose to "Restore Session" I did not
> get my tabs back. I think I only had 3-4 tabs open, one with Gmail and some
> other Bugzilla bugs loaded. But in all of my cases, I was crashing and then
> trying to session restore, not sleeping the machine or quitting normally.
> 
> I am also testing with Nightly on 10.14, not beta.

Just to be clear, since it seems you're the only one who can reproduce this -- are you also on the latest 10.14 beta? (Same build as comment 11?) Anything else unusual about your setup?

Comment 13

[Marcia Knous [:marcia]]

(In reply to Justin Dolske [:Dolske] from comment #12)
> (In reply to Marcia Knous [:marcia - needinfo? me] from comment #9)
> > In my case, I have the pref on to Restore Previous Session. The first time I
> > crashed, all of my tabs are restored. The second time I crashed (and every
> > subequent time) I always get the Session Restore page which give me the
> > option to restore. And sometimes when I chose to "Restore Session" I did not
> > get my tabs back. I think I only had 3-4 tabs open, one with Gmail and some
> > other Bugzilla bugs loaded. But in all of my cases, I was crashing and then
> > trying to session restore, not sleeping the machine or quitting normally.
> > 
> > I am also testing with Nightly on 10.14, not beta.
> 
> Just to be clear, since it seems you're the only one who can reproduce this
> -- are you also on the latest 10.14 beta? (Same build as comment 11?)
> Anything else unusual about your setup?

Yes, I am on the same build as Camelia. This is a relatively new machine that was deployed with 10.13 and then upgraded to 10.14 when the first developer build was available. Other than turning on the dark theme, I haven't done anything in the Apple System preferences. My nightly build has a few extensions installed.

I will try to reproduce this with a clean nightly profile as well. Is there any logging I can grab that might be useful?

Comment 14

[Justin Dolske [:Dolske]]

Yeah, there's a browser.sessionstore.debug pref that seems to enable some logging, and any browser console errors you see after starting up in a failed session.

Would also be interesting to know the contents of sessionstore-backups/ in your profile (specifically if recovery.jsonlz4 / recovery.baklz4 are there after you crash, and maybe stash a copy of them before restarting).

Mike: anything else of interest?

Comment 15

[Justin Dolske [:Dolske]]

(I'm moving this back onto the untriaged pile until we've got a better sense of the scale of the problem.)

Comment 16

[Justin Dolske [:Dolske]]

Given that we've only got 1 report of this still happening, and it's (apparently) 10.14 specific and that's still in flux, I don't think this is a realistic priority for 62.

Comment 17

[Justin Dolske [:Dolske]]

...and I suppose re-NI for any further logs/info from comment 14. Oops.

Comment 18

[Mike de Boer [:mikedeboer]]

Those bits of information you mentioned would be great - another thing would a copy of your main sessionstore.jsonlz4 in your profile directory - I can use it to reproduce the issue locally almost every time I get one.

Thanks!

Comment 19

[Justin Dolske [:Dolske]]

No actionable STR nor other apparent reports, so clearing tracking.

Comment 20

[Mike de Boer [:mikedeboer]]

Since this was spotted on the first 10.14 build that was available and thus far hasn't been reported again here or in other bugs, I'm closing this as WORKSFORME (as per comment 11).

Marcia, please feel free to reopen once you are able to reliably reproduce the issue on a recent 10.14 build. Thanks!