Closed
Bug 1467489
Opened 7 years ago
Closed 7 years ago
Convert lodash .some() to native ES6 JS
Categories
(Tree Management :: Treeherder: Frontend, defect, P3)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evct, Assigned: evct)
References
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_5) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.170 Safari/537.36 OPR/53.0.2907.68
Steps to reproduce:
Converting all _.some() (lodash) functions to native .some() (ES6 JS)
|
||
Updated•7 years ago
|
Assignee: nobody → oss
Blocks: 1466494
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P3
|
||
Comment 1•7 years ago
|
||
|
Assignee | |
Comment 2•7 years ago
|
||
_.some(array, predicate) was used without a predicate method, meaning that it was returning false if the array was empty, true on the contrary.
Since the some() method from ES6 doesn't allow an empty predicate, I will not use it.
See my solution in the PR.
|
|
||
Updated•7 years ago
|
Attachment #8984186 -
Flags: review?(cdawson)
|
||
Comment 3•7 years ago
|
||
Commented in PR.
|
||
Comment 4•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/ab66ec760a4b48fb81d8fc1813a25d9dfdc68914
Bug 1467489 - convert _.some() usages to ES6 (#3633)
|
|
||
Updated•7 years ago
|
Attachment #8984186 -
Flags: review?(cdawson) → review+
|
|
||
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•