1467496 - Simplify JSOP_LOOPENTRY handling in IonBuilder

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[Jan de Mooij [:jandem]]

Attachment: Patch

The CFG generator skips the JSOP_LOOPENTRY ops, and IonBuilder has to call initLoopEntry to insert interrupt checks. It's much simpler to not skip these ops in the first place and then JSOP_LOOPENTRY can be compiled by IonBuilder like any other op and this way we always know its pc.

I ran into this while working on bug 1382650 and it's also causing problems for bhackett in bug 1465289, so I split off my fix for this from the patch for bug 1382650.

Comment 1

[Jan de Mooij [:jandem]]

I tested this on some benchmarks and verified for/while/do-while loops still enter Ion via OSR and we have a single interrupt check.

Comment 2

[Brian Hackett [Laid off!]]

Comment on attachment 8984188 [details] [diff] [review]
Patch

Review of attachment 8984188 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c9ee59766684
Simplify JSOP_LOOPENTRY handling in IonBuilder. r=bhackett

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/c9ee59766684