1467521 - Sync engine toggles have persistence issues

Status: RESOLVED WORKSFORME

(Firefox for iOS :: Sync, enhancement)

Description

[Justin D'Arcangelo [:justindarc]]

When toggling a Sync engine off, it is almost impossible to toggle it back on again because the setting will then toggle every time you go back into the settings screen after a Sync.

Comment 1

[Justin D'Arcangelo [:justindarc]]

Attachment: GitHub Pull Request

I'm not 100% sure if this fixed my issue now. Is it possible that filling out the `enginesEnablements` (as opposed to only listing the toggles that changed) somehow fixed an issue with the state of my FxA account?

Comment 2

[Justin D'Arcangelo [:justindarc]]

Attachment: Screen Shot 2018-06-08 at 1.02.21 PM.png

On a clean-install of master (without my patch), I sign into Sync and after the initial Sync, this is what I get. You can see my settings on Desktop, but for some reason, some engines are seemingly randomly turned off.

Note, this doesn't happen with my patch, but as you noted in my PR, toggling engines on another client is unable to propagate to iOS with my patch :-/

Comment 3

[Justin D'Arcangelo [:justindarc]]

Closing this bug now. The problem seems to have been with my account. Toggling all the engines off and on again on desktop seems to have fixed the issue.