1467541 - Layout Debugger is broken in packaged builds

Status: RESOLVED FIXED

(Core :: Layout, defect, P4)

Description

[(no longer active)]

In a debug build, the Layout Debugger menu item under Tools doesn't do anything any more.  I think this is because the https://searchfox.org/mozilla-central/source/layout/tools/layout-debug/chrome.manifest file isn't being packaged any more, so chrome://layoutdebug/content/layoutdebug.xul ends up becoming an invalid link.  When clicking that menu item, the following gets printed to console:

Couldn't convert chrome URL: chrome://layoutdebug/content/layoutdebug.xul

Comment 1

[Ian Moody [:Kwan] (UTC+1)]

Attachment: Bug 1467541 - Remove dead layout debug files.

No longer used since it stopped being built as an extension.

Comment 2

[Ian Moody [:Kwan] (UTC+1)]

Attachment: Bug 1467541 - Package layout debugger in debug builds.

Comment 3

[Ian Moody [:Kwan] (UTC+1)]

Attachment: Bug 1467541 - Add a test for opening the layout debugger.

Comment 4

[Ian Moody [:Kwan] (UTC+1)]

Test fails prior to the packaging change:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=926c2b0cf8106d40a006c3c3394dfdc5db1cf230&selectedJob=191728022
(I'm not sure why try syntax did that with the xpcshell jobs)

And passes after:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cd75012ec2227da23da0a96c027a4399148a26b8&selectedJob=191736337

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8997016 [details]
Bug 1467541 - Remove dead layout debug files.

David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-7 has approved the revision.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8997018 [details]
Bug 1467541 - Package layout debugger in debug builds.

David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-7 has approved the revision.

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I didn't realize this bug was only about packaged builds... but then again, it seems like it is, since the layout debugger works fine for me in my own tree, so I guess it is only about packaged builds.  Or am I confused?

Comment 8

[Ian Moody [:Kwan] (UTC+1)]

Nope, not confused :) This came up in the context of bug 1477897, where heycam couldn't regression test since it hasn't worked in packaged builds since possibly the change from being an extension (certainly the oldest debug builds I could find, which was Fx44 or so)

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 8997228 [details]
Bug 1467541 - Add a test for opening the layout debugger.

David Baron :dbaron: 🏴󠁵󠁳󠁣󠁡󠁿 ⌚UTC-7 has approved the revision.

Comment 10

[Ian Moody [:Kwan] (UTC+1)]

Thanks for the reviews dbaron.

Not sure how checkin-needed is going to go with phab, guess we'll find out.
Comment 4 has a green try run (an older version of the test, but I've run the new version locally both packaged and unpackaged).

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/db5198c10a4b
Package layout debugger in debug builds. r=dbaron
https://hg.mozilla.org/integration/mozilla-inbound/rev/5ed009eaad1c
Remove dead layout debug files. r=dbaron
https://hg.mozilla.org/integration/mozilla-inbound/rev/2a818faa9c1b
Add a test for opening the layout debugger. r=dbaron

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/db5198c10a4b
https://hg.mozilla.org/mozilla-central/rev/5ed009eaad1c
https://hg.mozilla.org/mozilla-central/rev/2a818faa9c1b