1467643 - Don't expose help property in A11y Inspector

Status: RESOLVED FIXED

(DevTools :: Accessibility Tools, enhancement)

Description

[James Teh [:Jamie]]

We should consider removing the help property from the Accessibility Inspector. At present, there is no "real" implementation of this in Gecko; it always returns an empty string. This is likely to be confusing for users. We can always add it back if anyone ever implements it.

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: 1467381 patch

Had to add two dependencies in browser.ini (that inspector's shared-head relies on) as the tests stopped working locally after clobber.

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: 1467643 patch

Sorry wrong bug number on the patch.

Comment 3

[Patrick Brosset <:pbro>]

Comment on attachment 8985370 [details] [diff] [review]
1467643 patch

Review of attachment 8985370 [details] [diff] [review]:
-----------------------------------------------------------------

It looks like the front-end for the tool does *not* use this property today, looking quickly through the code. Is that correct?

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

(In reply to Patrick Brosset <:pbro> from comment #3)
> Comment on attachment 8985370 [details] [diff] [review]
> 1467643 patch
> 
> Review of attachment 8985370 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> It looks like the front-end for the tool does *not* use this property today,
> looking quickly through the code. Is that correct?

Well it was a row in a11y properties sidebar but never populated. Is that still alright or do I need to account for backward compat?

Comment 5

[Patrick Brosset <:pbro>]

I think it's alright. Backward compat is impacted when some client-side code has some knowledge of actors, their methods, or what their return and when any of that may change depending on the target being debugged.
In your case, the UI never assumed anything about this property, so you should be fine.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d7ff9efd67f
remove 'help' accessibility property from accessibility inspector. r=pbro

Comment 7

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/5d7ff9efd67f