Closed Bug 1467643 Opened 2 years ago Closed 2 years ago

Don't expose help property in A11y Inspector

Categories

(DevTools :: Accessibility Tools, enhancement)

enhancement
Not set
normal

Tracking

(firefox62 fixed)

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: Jamie, Assigned: yzen)

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 1 obsolete file)

We should consider removing the help property from the Accessibility Inspector. At present, there is no "real" implementation of this in Gecko; it always returns an empty string. This is likely to be confusing for users. We can always add it back if anyone ever implements it.
Product: Firefox → DevTools
Attached patch 1467381 patch (obsolete) — Splinter Review
Had to add two dependencies in browser.ini (that inspector's shared-head relies on) as the tests stopped working locally after clobber.
Attachment #8985369 - Flags: review?(pbrosset)
Assignee: nobody → yzenevich
Status: NEW → ASSIGNED
Attached patch 1467643 patchSplinter Review
Sorry wrong bug number on the patch.
Attachment #8985369 - Attachment is obsolete: true
Attachment #8985369 - Flags: review?(pbrosset)
Attachment #8985370 - Flags: review?(pbrosset)
Comment on attachment 8985370 [details] [diff] [review]
1467643 patch

Review of attachment 8985370 [details] [diff] [review]:
-----------------------------------------------------------------

It looks like the front-end for the tool does *not* use this property today, looking quickly through the code. Is that correct?
Attachment #8985370 - Flags: review?(pbrosset) → review+
(In reply to Patrick Brosset <:pbro> from comment #3)
> Comment on attachment 8985370 [details] [diff] [review]
> 1467643 patch
> 
> Review of attachment 8985370 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> It looks like the front-end for the tool does *not* use this property today,
> looking quickly through the code. Is that correct?

Well it was a row in a11y properties sidebar but never populated. Is that still alright or do I need to account for backward compat?
Flags: needinfo?(pbrosset)
I think it's alright. Backward compat is impacted when some client-side code has some knowledge of actors, their methods, or what their return and when any of that may change depending on the target being debugged.
In your case, the UI never assumed anything about this property, so you should be fine.
Flags: needinfo?(pbrosset)
Pushed by yura.zenevich@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5d7ff9efd67f
remove 'help' accessibility property from accessibility inspector. r=pbro
https://hg.mozilla.org/mozilla-central/rev/5d7ff9efd67f
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
You need to log in before you can comment on or make changes to this bug.