1467692 - Create SelectAllInternal() for used by editor itself

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

We need to distinguish whether SelectAll request comes from outside of editor or not since SelectAll() is called by TextEditor internally. So, we need to create SelectAllInternal() and make TextEditor use it.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=05911c0ae936705efc95bbfe6966d0cd06ce48b2

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1467692 - Create EditorBase::SelectAllInternal() for internal use

For preparing to fix bug 1465702, we need to split public methods of editor
which are used by both outside and itself or friends.

SelectAll() is used by both outside and TextEditor.  So, we need to create
SelectAllInternal() and make TextEditor use it instead.

Review commit: https://reviewboard.mozilla.org/r/250184/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/250184/

Comment 3

[Makoto Kato [:m_kato]]

Comment on attachment 8984365 [details]
Bug 1467692 - Create EditorBase::SelectAllInternal() for internal use

https://reviewboard.mozilla.org/r/250184/#review256886

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aaa10924c04b
Create EditorBase::SelectAllInternal() for internal use r=m_kato

Comment 5

[Eliza Balazs [:ebalazs_]]

https://hg.mozilla.org/mozilla-central/rev/aaa10924c04b