Don't return null from getComputedStyle when there's no presentation.
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Tracking
()
People
(Reporter: emilio, Assigned: emilio)
References
(Blocks 1 open bug)
Details
(Keywords: dev-doc-complete, site-compat)
Attachments
(3 files)
Assignee | ||
Comment 1•7 years ago
|
||
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 6•7 years ago
|
||
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 10•7 years ago
|
||
Assignee | ||
Comment 11•7 years ago
|
||
Updated•7 years ago
|
Comment 12•7 years ago
|
||
mozreview-review |
Comment 13•7 years ago
|
||
mozreview-review |
Comment 14•7 years ago
|
||
mozreview-review |
Comment 15•7 years ago
|
||
Comment 18•7 years ago
|
||
bugherder |
Updated•7 years ago
|
Comment 22•7 years ago
|
||
Comment 24•7 years ago
|
||
Comment 25•7 years ago
|
||
Comment 26•6 years ago
|
||
Hi All,
I am facing this issue in Firefox 65.0.5esr release , While I am having no trouble , when i ran same code on Firefox 65.
As i just want to know that whether this fix pushed into Firefox esr release or not ,please let me know.
If not pushed into esr , when it will get push into Firefox esr release , if you know any timeline , please let me know.
Thanks.
Assignee | ||
Comment 27•6 years ago
|
||
(In reply to ankit_k_chaniyara from comment #26)
I am facing this issue in Firefox 65.0.5esr release , While I am having no trouble , when i ran same code on Firefox 65.
You mean Firefox 60.5esr, right?
As i just want to know that whether this fix pushed into Firefox esr release or not ,please let me know.
If not pushed into esr , when it will get push into Firefox esr release , if you know any timeline , please let me know.
I don't think there's any particular plan to push it to ESR, but if you want to make a case for that, please do. I don't think it's a very risky patch to uplift.
Comment 28•6 years ago
|
||
Sorry for typo , Yes i mean Firefox 60.5.0esr ,
Thanks for information.
I am new in this bugzilla , so could you please give me some information about how to patch this thing into esr release and how to work with that.
Maybe it's silly question , but if you give some lead on that , it will be very helpful.
Assignee | ||
Comment 29•6 years ago
|
||
If you go to the patch "Details" page: https://bugzilla.mozilla.org/attachment.cgi?id=8984384&action=edit
You can see a approval-mozilla-esr flag, you can change it to "?", and that gives you an approval request form which you need to fill in order to get the release managers to look at it.
Comment 30•6 years ago
|
||
[Tracking Requested - why for this release]: I ran project in firefox 65 , which works very fine , but it got break in firefox 60.5.0esr , our project used by a customer who uses esr release of firefox to run our project , and we are using GWT as our UI component , so it is not possible for us to change structure [ entire code base is in java] , please release this patch for Firefox-esr60 release also.
Assignee | ||
Comment 31•6 years ago
|
||
I'm not sure why you ni?d me? If you need something from me please let me know.
Comment 32•6 years ago
|
||
Sorry for that , but i did not find "approval-mozilla-esr" flag , for that may be i need an account with more privileges , so that's why i just googled it and found out that you can do in this way.
Sorry for bothering you again , but this is very serious issue for me as a product itself is not working because of this issue , and we do not have other alternative to solve this , until and unless this patch will get release in next esr release.
Need --> please , i just want to have this patch in esr release.
please help me out for this.
Thanks,
Ankit
Assignee | ||
Comment 33•6 years ago
|
||
Comment on attachment 8984384 [details]
Bug 1467722: Do not throw when we don't have a style, but just return an empty style.
ESR Uplift Approval Request
- If this is not a sec:{high,crit} bug, please state case for ESR consideration: Filing on behalf of comment 30, see that comment.
- User impact if declined: See comment 30
- Fix Landed on Version: 62
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): It's not a too hard patch to uplift.
- String or UUID changes made by this patch: none
Assignee | ||
Comment 34•6 years ago
|
||
(In reply to ankit_k_chaniyara from comment #32)
Sorry for that , but i did not find "approval-mozilla-esr" flag , for that may be i need an account with more privileges , so that's why i just googled it and found out that you can do in this way.
I filed the request, see above. Not sure if people will take it though.
Sorry for bothering you again , but this is very serious issue for me as a product itself is not working because of this issue , and we do not have other alternative to solve this , until and unless this patch will get release in next esr release.
Why isn't using a try { } catch () {} block in an appropriate place not an acceptable solution?
Comment 35•6 years ago
|
||
I filed the request, see above. Not sure if people will take it though.
Thanks a lot for that.
Why isn't using a try { } catch () {} block in an appropriate place not an acceptable solution?
Because we are using GWT , where in a lot of places we have used that , almost every page , and more of it will convert Java into generated Javascript , and it is throwing exception. so we can not put that code in there.
Comment 36•6 years ago
|
||
Updated•6 years ago
|
Description
•