1467799 - Make all TextEditor::GetDocumentIsEmpty() callers use TextEditor::DocumentIsEmpty()

Status: RESOLVED FIXED

(Core :: DOM: Editor, enhancement, P3)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

TextEditor::GetDocumentIsEmpty() is an nsIEditor attribute. So, all callers in C++ code should use TextEditor::DocumentIsEmpty() instead.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0ea864ab71db163d09c068bef4316376182d5683

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1467799 - part 1: Remove implementation of EditorBase::GetDocumentIsEmpty() and rename TextEditor::DocumentIsEmpty() to TextEditor::IsEmpty()

EditorBase::GetDocumentIsEmpty() is never called since it's overridden by
TextEditor::GetDocumentIsEmtpy() and never called directly.  So, we can remove
its implementation.

Additionally, DocumentIsEmpty() is redundant. We can make it just IsEmpty().

Review commit: https://reviewboard.mozilla.org/r/257772/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257772/

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1467799 - part 2: Stop using nsIEditor::GetDocumentIsEmpty() from C++ code

nsIEditor::GetDocumentIsEmpty() is a virtual code and there is non-virtual
method, TextEditor::IsEmpty().  So, any callers in C++ should use
TextEditor::IsEmpty() instead.

Review commit: https://reviewboard.mozilla.org/r/257774/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/257774/

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a51308842f40806e3c346ee094ad495e1f56e6fa

Comment 5

[Makoto Kato [:m_kato]]

Comment on attachment 8992932 [details]
Bug 1467799 - part 1: Remove implementation of EditorBase::GetDocumentIsEmpty() and rename TextEditor::DocumentIsEmpty() to TextEditor::IsEmpty()

https://reviewboard.mozilla.org/r/257772/#review264946

Comment 6

[Makoto Kato [:m_kato]]

Comment on attachment 8992933 [details]
Bug 1467799 - part 2: Stop using nsIEditor::GetDocumentIsEmpty() from C++ code

https://reviewboard.mozilla.org/r/257774/#review264948

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ee06131120fb
part 1: Remove implementation of EditorBase::GetDocumentIsEmpty() and rename TextEditor::DocumentIsEmpty() to TextEditor::IsEmpty() r=m_kato
https://hg.mozilla.org/integration/autoland/rev/6a0dbf818f7f
part 2: Stop using nsIEditor::GetDocumentIsEmpty() from C++ code r=m_kato

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/ee06131120fb
https://hg.mozilla.org/mozilla-central/rev/6a0dbf818f7f