Closed Bug 1467799 Opened Last year Closed Last year

Make all TextEditor::GetDocumentIsEmpty() callers use TextEditor::DocumentIsEmpty()

Categories

(Core :: Editor, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: masayuki, Assigned: masayuki)

References

Details

Attachments

(2 files)

TextEditor::GetDocumentIsEmpty() is an nsIEditor attribute. So, all callers in C++ code should use TextEditor::DocumentIsEmpty() instead.
Priority: -- → P3
Comment on attachment 8992932 [details]
Bug 1467799 - part 1: Remove implementation of EditorBase::GetDocumentIsEmpty() and rename TextEditor::DocumentIsEmpty() to TextEditor::IsEmpty()

https://reviewboard.mozilla.org/r/257772/#review264946
Attachment #8992932 - Flags: review?(m_kato) → review+
Comment on attachment 8992933 [details]
Bug 1467799 - part 2: Stop using nsIEditor::GetDocumentIsEmpty() from C++ code

https://reviewboard.mozilla.org/r/257774/#review264948
Attachment #8992933 - Flags: review?(m_kato) → review+
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/ee06131120fb
part 1: Remove implementation of EditorBase::GetDocumentIsEmpty() and rename TextEditor::DocumentIsEmpty() to TextEditor::IsEmpty() r=m_kato
https://hg.mozilla.org/integration/autoland/rev/6a0dbf818f7f
part 2: Stop using nsIEditor::GetDocumentIsEmpty() from C++ code r=m_kato
https://hg.mozilla.org/mozilla-central/rev/ee06131120fb
https://hg.mozilla.org/mozilla-central/rev/6a0dbf818f7f
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.