Closed Bug 1467805 Opened 2 years ago Closed 2 years ago

Debugger Release 64

Categories

(DevTools :: Debugger, defect, P3)

defect

Tracking

(firefox62 fixed)

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: davidwalsh, Assigned: davidwalsh)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Assignee: nobody → dwalsh
Priority: -- → P3
Attached patch release-64.patch (obsolete) — Splinter Review
Attachment #8984458 - Flags: review?(jdescottes)
Comment on attachment 8984458 [details] [diff] [review]
release-64.patch

Review of attachment 8984458 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good but needs sync with https://github.com/devtools-html/debugger.html/pull/6490 first.

::: devtools/client/debugger/new/README.mozilla
@@ -5,2 @@
>  
> -Comparison: https://github.com/devtools-html/debugger.html/compare/release-61...release-62

Damn, I landed the version without readme update last time ...

::: devtools/client/debugger/new/test/mochitest/browser_dbg-layout-changes.js
@@ -16,4 @@
>    const layouts = [
>      ["vertical", "window:small"],
>      ["horizontal", "bottom"],
> -    ["vertical", "right"],

Needs synchronization from https://bugzilla.mozilla.org/show_bug.cgi?id=1192642
Attachment #8984458 - Flags: review?(jdescottes) → review+
Attachment #8984458 - Attachment is obsolete: true
Attachment #8984527 - Flags: review?(jdescottes)
Comment on attachment 8984527 [details] [diff] [review]
release-64-3.patch

Review of attachment 8984527 [details] [diff] [review]:
-----------------------------------------------------------------

thanks for the update!
Attachment #8984527 - Flags: review?(jdescottes) → review+
Comment on attachment 8984527 [details] [diff] [review]
release-64-3.patch

Review of attachment 8984527 [details] [diff] [review]:
-----------------------------------------------------------------

Will amend myself, but the commit message is missing the bug number and has a "@" before the reviewer name
https://hg.mozilla.org/mozilla-central/rev/0485c263b1d3
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Product: Firefox → DevTools
v64+shouldComponentUpdate vs v63 : no performance difference.
v64 vs v63: -12% on pause, -5% on stepin
v64+shouldComponentUpdate vs v64: +11% on pause, +5% on stepin

This confirms that removing the shouldComponentUpdate is responsible for the performance regression.
You need to log in before you can comment on or make changes to this bug.