1467915 - Give a surface to background sessions in TestRunnerActivity

Status: RESOLVED FIXED

(GeckoView :: General, enhancement, P2)

Description

[James Willcox (:snorp) ([e-mail]) (he/him)]

Some tests use window.open() and then run things that need the compositor to function properly, e.g. off main thread animations. We need to give background sessions a Surface for this to work.

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

Attachment: Bug 1467915 - Connect a display to background windows in TestRunnerActivity

This is needed to make some tests pass that rely on the Compositor
to work as expected.

Review commit: https://reviewboard.mozilla.org/r/250476/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/250476/

Comment 2

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8984604 [details]
Bug 1467915 - Connect a display to background windows in TestRunnerActivity

https://reviewboard.mozilla.org/r/250476/#review256934

::: mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/TestRunnerActivity.java:121
(Diff revision 1)
> +        session.acquireDisplay().surfaceChanged(surface, mView.getWidth(), mView.getHeight());
> +        return session;
> +    }
> +
> +    private void closeSession(GeckoSession session) {
> +        session.acquireDisplay().surfaceDestroyed();

Should be calling `releaseDisplay` instead of `acquireDisplay`.

::: mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/TestRunnerActivity.java:121
(Diff revision 1)
> +        session.acquireDisplay().surfaceChanged(surface, mView.getWidth(), mView.getHeight());
> +        return session;
> +    }
> +
> +    private void closeSession(GeckoSession session) {
> +        session.acquireDisplay().surfaceDestroyed();

Should be calling `releaseDisplay` instead of `acquireDisplay`.

Comment 3

[James Willcox (:snorp) ([e-mail]) (he/him)]

Comment on attachment 8984604 [details]
Bug 1467915 - Connect a display to background windows in TestRunnerActivity

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/250476/diff/1-2/

Comment 4

[Eugen Sawin [:esawin]]

Comment on attachment 8984604 [details]
Bug 1467915 - Connect a display to background windows in TestRunnerActivity

https://reviewboard.mozilla.org/r/250476/#review260416

::: mobile/android/geckoview/src/androidTest/java/org/mozilla/geckoview/test/TestRunnerActivity.java:115
(Diff revision 2)
>          final GeckoSession session = new GeckoSession(settings);
>          session.setNavigationDelegate(mNavigationDelegate);
>          return session;
>      }
>  
> +    private GeckoSession createBackgroundSession(GeckoSessionSettings settings) {

final.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3820ad4c882b
Connect a display to background windows in TestRunnerActivity r=esawin

Comment 6

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/3820ad4c882b

Comment 7

[Arthur Iakab [arthur_iakab]]

https://hg.mozilla.org/mozilla-central/rev/3820ad4c882b