1467975 - Convert lodash .each() to native ES6 JS

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, defect, P3)

Description

[srinivas]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_4) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.181 Safari/537.36



Actual results:

we are using 
// Underscore/Lodash
_.each([1, 2, 3], function (value, index) {
  console.log(value)
})


Expected results:

we are going to use 
// Native
[1, 2, 3].forEach(function (value, index) {
  console.log(value)
})

Comment 1

[Ed Morley [:emorley]]

Hi! Thank you for working on this :-)

Note that _.each() also supports Objects as well as arrays, so some of the current uses will need to be replaced by Object.entries() rather than Array.prototype.forEach():
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/entries

Comment 2

[srinivas]

(In reply to Ed Morley [:emorley] from comment #1)
> Hi! Thank you for working on this :-)
> 
> Note that _.each() also supports Objects as well as arrays, so some of the
> current uses will need to be replaced by Object.entries() rather than
> Array.prototype.forEach():
> https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/
> Global_Objects/Object/entries

Thanks for help emorley. Can you please help me join #treeherder IRC? is there new #name for treeherder?

Comment 3

[srinivas]

 I fixed in almost all places except 2 files. They are resultsets_store.js and pinboard.js. I can not invoke break point for both files. Can you please tell which part of UI render these files.

Comment 4

[Cameron Dawson [:camd]]

srinivas:  ``resultsets_store.js`` is what holds all the main job data, so that file is used all the time.  It will depend on which action you're doing.  ``pinboard.js`` recently changed and I don't think it contains any ``_.each`` functions any longer so you won't need to deal with that one.

I don't see your PR yet, so please let me know which function in ``resultsets_store.js`` you're trying to debug.  If it's ``addRunnableJobs`` then you get to that with the drop-down at the header of each push that says "add new jobs".

Comment 5

[srinivas]

Hi emorley:
 I committed my changes and trying to push to detail-panel-fixes  brach in sourcetree. but i am getting the below error.

git -c diff.mnemonicprefix=false -c core.quotepath=false -c credential.helper=sourcetree push -v --tags origin refs/heads/detail-panel-fixes:refs/heads/detail-panel-fixes 
Pushing to https://github.com/mozilla/treeherder
remote: Permission to mozilla/treeherder.git denied to git-srinivas.
fatal: unable to access 'https://github.com/mozilla/treeherder/': The requested URL returned error: 403
Completed with errors, see above

Comment 6

[Ed Morley [:emorley]]

Hi! It looks like git is pushing to our copy of the repository (for which you won't have permissions), rather than your fork of it. See:
https://guides.github.com/activities/forking/
https://help.github.com/articles/fork-a-repo/

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3699

Comment 8

[Cameron Dawson [:camd]]

Just back from PTO and had a couple higher priority things than this.  I will do my very best to review this tomorrow.

Comment 9

[Cameron Dawson [:camd]]

Comment on attachment 8986828 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3699

Feedback in PR.  Thanks!

Comment 10

[Ed Morley [:emorley]]

Cancelling needinfo until the PR is updated. After updating it please comment in the PR (or here) so we know to take another look :-)

Comment 11

[srinivas]

Hi camd, I fixed the review changes suggested. Please check :)

Comment 12

[Cameron Dawson [:camd]]

Left comments in the PR.  Needs a rebase.  Otherwise, the code looks good.

Comment 13

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/a664f8c6a9e9d015486b0da0e4e964522b7096c7
Bug 1467975 - Convert lodash .each() to native ES6 JS (#3699)

Comment 14

[Cameron Dawson [:camd]]

Comment on attachment 8986828 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3699

Thanks for the PR!

Comment 15

[srinivas]

(In reply to Cameron Dawson [:camd] from comment #14)
> Comment on attachment 8986828 [details] [review]
> Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3699
> 
> Thanks for the PR!
Welcome :camd :)