59 bytes, text/x-review-board-request
Currently, we load the grid highlighter settings when we initialize the HighlightersOverlay and this causes an expensive dispatch/render call. We can simplify this by simply setting these values when the reducer is initialized.
You will see I used a getter for the INITIAL_HIGHLIGHTER_SETTINGS because otherwise the prefs are cached across closing and re-opening of the toolbox.
Comment on attachment 8984672 [details] Bug 1468002 - Set the initial grid highlighter settings in the reducer. https://reviewboard.mozilla.org/r/250532/#review256926
Attachment #8984672 - Flags: review?(pbrosset) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/4bed64165131 Set the initial grid highlighter settings in the reducer. r=pbro
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox62: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
You need to log in before you can comment on or make changes to this bug.