Closed Bug 1468002 Opened 2 years ago Closed 2 years ago

Set the initial grid highlighter settings in the reducer

Categories

(DevTools :: Inspector, enhancement, P3)

enhancement

Tracking

(firefox62 fixed)

RESOLVED FIXED
Firefox 62
Tracking Status
firefox62 --- fixed

People

(Reporter: gl, Assigned: gl)

References

Details

Attachments

(1 file)

Currently, we load the grid highlighter settings when we initialize the HighlightersOverlay and this causes an expensive dispatch/render call. We can simplify this by simply setting these values when the reducer is initialized.
Blocks: 1317102
You will see I used a getter for the INITIAL_HIGHLIGHTER_SETTINGS because otherwise the prefs are cached across closing and re-opening of the toolbox.
Comment on attachment 8984672 [details]
Bug 1468002 - Set the initial grid highlighter settings in the reducer.

https://reviewboard.mozilla.org/r/250532/#review256926
Attachment #8984672 - Flags: review?(pbrosset) → review+
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4bed64165131
Set the initial grid highlighter settings in the reducer. r=pbro
https://hg.mozilla.org/mozilla-central/rev/4bed64165131
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.