Set the initial grid highlighter settings in the reducer

RESOLVED FIXED in Firefox 62

Status

enhancement
P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: gl, Assigned: gl)

Tracking

unspecified
Firefox 62
Dependency tree / graph

Firefox Tracking Flags

(firefox62 fixed)

Details

Attachments

(1 attachment)

Assignee

Description

a year ago
Currently, we load the grid highlighter settings when we initialize the HighlightersOverlay and this causes an expensive dispatch/render call. We can simplify this by simply setting these values when the reducer is initialized.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Assignee

Updated

a year ago
Blocks: 1317102
Assignee

Comment 3

a year ago
You will see I used a getter for the INITIAL_HIGHLIGHTER_SETTINGS because otherwise the prefs are cached across closing and re-opening of the toolbox.

Comment 4

a year ago
mozreview-review
Comment on attachment 8984672 [details]
Bug 1468002 - Set the initial grid highlighter settings in the reducer.

https://reviewboard.mozilla.org/r/250532/#review256926
Attachment #8984672 - Flags: review?(pbrosset) → review+

Comment 5

a year ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4bed64165131
Set the initial grid highlighter settings in the reducer. r=pbro

Comment 6

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/4bed64165131
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 62

Updated

a year ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.