1468002 - Set the initial grid highlighter settings in the reducer

Status: RESOLVED FIXED

(DevTools :: Inspector, enhancement, P3)

Description

[Gabriel Luong [:gl] (ΦωΦ)]

Currently, we load the grid highlighter settings when we initialize the HighlightersOverlay and this causes an expensive dispatch/render call. We can simplify this by simply setting these values when the reducer is initialized.

Comment 1

[Gabriel Luong [:gl] (ΦωΦ)]

Attachment: Bug 1468002 - Set the initial grid highlighter settings in the reducer.

Review commit: https://reviewboard.mozilla.org/r/250532/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/250532/

Comment 2

[Gabriel Luong [:gl] (ΦωΦ)]

Comment on attachment 8984672 [details]
Bug 1468002 - Set the initial grid highlighter settings in the reducer.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/250532/diff/1-2/

Comment 3

[Gabriel Luong [:gl] (ΦωΦ)]

You will see I used a getter for the INITIAL_HIGHLIGHTER_SETTINGS because otherwise the prefs are cached across closing and re-opening of the toolbox.

Comment 4

[Patrick Brosset <:pbro>]

Comment on attachment 8984672 [details]
Bug 1468002 - Set the initial grid highlighter settings in the reducer.

https://reviewboard.mozilla.org/r/250532/#review256926

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4bed64165131
Set the initial grid highlighter settings in the reducer. r=pbro

Comment 6

[Cristina Coroiu [:ccoroiu]]

https://hg.mozilla.org/mozilla-central/rev/4bed64165131