1468063 - Unable to save several media files at once in Page Info

Status: RESOLVED FIXED

(SeaMonkey :: Page Info, defect)

Description

[Frank-Rainer Grahl (:frg)]

+++ This bug was initially created as a clone of Bug #796994 +++

Bug 796994 introduced an error in Page Info. You are only able to save one media file at a time. If you select more than one file and try to save them into a folder a undefined rowArray will be logged in console. Probably during a rebase in development some lines got lost.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1468063-pageinfo.patch

[Approval Request Comment]
Regression caused by (bug #): 796994
User impact if declined: broken functionality
Testing completed (on m-c, etc.): c-r 2.53
Risk to taking this patch (and alternatives if risky): none already broken.
String changes made by this patch: --

Comment 2

[[e-mail]]

Comment on attachment 8984728 [details] [diff] [review]
1468063-pageinfo.patch

>-  var count = tree.view.selection.count;
>-  if (count == 1) {
>-    var item = getSelectedImage(tree);
>+  var rowArray = getSelectedRows(tree);
>+  if (rowArray.length == 1) {
>+    let row = rowArray[0];
>+    let item = gImageView.data[row][COL_IMAGE_NODE]; 
>     var url = gImageView.data[tree.currentIndex][COL_IMAGE_ADDRESS];
Shouldn't this be data[row] as well?

Comment 3

[Frank-Rainer Grahl (:frg)]

Attachment: 1468063-pageinfo-V2.patch

Yes should be row. It worked but if you steal code you should steal everything :) Thanks for catching it.

Comment 4

[Frank-Rainer Grahl (:frg)]

I also introduced a traing blank. Will fix it either in the next round or during checkin.

Comment 5

[Ian Neal]

Comment on attachment 8984743 [details] [diff] [review]
1468063-pageinfo-V2.patch

LGTM r/a=me

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f19420b1c733
Fix undefined rowArray when trying to saving more than one media file in Page Info. r=IanN

Comment 7

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/releases/comm-esr60/rev/10975c1f493339a8a9bdcef7597bb359dfc4fbd4