Closed Bug 1468071 Opened 2 years ago Closed 2 years ago

small followup to proxy bypass on windows via smb

Categories

(Core :: Networking: File, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla62
Tracking Status
firefox-esr52 --- unaffected
firefox-esr60 --- unaffected
firefox60 --- unaffected
firefox61 --- fixed
firefox62 --- fixed

People

(Reporter: mayhemer, Assigned: mayhemer)

References

Details

(Keywords: privacy, sec-other, Whiteboard: [tor][sec-high for Tor][necko-triaged])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1413868 +++

The path "normalizer" is implemented recursively (each path element recurses) there is a slight possibility a content page could cause a stack overflow with a long file:///// url when the functionality in bug 1413868 is enabled (TOR browser only).

This applies only to 62 and 61 (current Nightly and Beta).  Backported patches for ESR52 and ESR60 already do a loop instead of a recursion.
No longer depends on: 1463786
Attached patch v1Splinter Review
Approval Request Comment
[Feature/Bug causing the regression]: bug 1413868
[User impact if declined]: A TOR browser build based on Beta 60 and network.file.disable_unc_paths switched to true there is a small chance for content-induced stack overflow crash of the main thread (any process)
[Is this code covered by automated tests?]: yes
[Has the fix been verified in Nightly?]: n/w
[Needs manual test from QE? If yes, steps to reproduce]: no need
[List of other uplifts needed for the feature/fix]: 1413868, which already is on beta
[Is the change risky?]: no
[Why is the change risky/not risky?]: a simple change to an already tested and landed code (small logic change)
[String changes made/needed]: none
Attachment #8984736 - Flags: review?(valentin.gosu)
Attachment #8984736 - Flags: approval-mozilla-beta?
Attachment #8984736 - Flags: review?(valentin.gosu) → review+
Is this ready to push to inbound?
Flags: needinfo?(honzab.moz)
(In reply to Ryan VanderMeulen [:RyanVM] from comment #2)
> Is this ready to push to inbound?

Yes!
Flags: needinfo?(honzab.moz)
Keywords: checkin-needed
Comment on attachment 8984736 [details] [diff] [review]
v1

Approved for 61.0b14 too.
Attachment #8984736 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
https://hg.mozilla.org/mozilla-central/rev/ed974d95994399519ac0e13ef4d7e857f59cac33
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla62
Group: core-security-release
Group: network-core-security → core-security-release
Group: core-security-release
You need to log in before you can comment on or make changes to this bug.