1468089 - Add a few WritingMode convenience methods to simplify consumers that are parameterized on axis

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P2)

Description

[Mats Palmgren (inactive)]

In Grid layout code it's quite common for methods to be axis-neutral,
e.g. methods that takes a LogicalAxis as a param which is then
invoked once for each axis.  Accessing the relevant axis-data from
a LogicalSize or LogicalMargin etc is a bit tedious (and error prone)
though since you have to write something like:
size = aAxis == eLogicalAxisInline ? x.ISize(wm) : x.BSize(wm);
It would convenient to write instead:
size = x.Size(aAxis, wm);

Comment 1

[Mats Palmgren (inactive)]

Attachment: Add a few convenience methods to simplify consumers that are parameterized on axis

These are methods that I'm using in my subgrid patches.  We can add more later
to simplify existing code...

Comment 2

[Mats Palmgren (inactive)]

FTR, CSSAlignUtils has a few existing uses that could be simplified, e.g.:
https://searchfox.org/mozilla-central/source/layout/generic/CSSAlignUtils.cpp#18

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/63daa6667de7
Add a few convenience methods to simplify consumers that are parameterized on axis.  r=jfkthame

Comment 4

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/63daa6667de7