Closed
Bug 1468092
Opened 7 years ago
Closed 7 years ago
Convert lodash .sum() to native ES6
Categories
(Tree Management :: Treeherder: Frontend, defect, P3)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rajk, Assigned: rajk)
References
Details
Attachments
(1 file)
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3359.139 Safari/537.36
Steps to reproduce:
Convert lodash .sum() to native ES6 using .reduce()
|
||
Updated•7 years ago
|
Assignee: nobody → rajesh.kathiriya507
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Priority: -- → P3
|
||
Comment 1•7 years ago
|
||
|
|
||
Updated•7 years ago
|
Attachment #8985846 -
Flags: review?(cdawson)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8985846 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3675
This looks good to me. I know I could force merge, but I'll give you a chance to approve his change. :)
Attachment #8985846 -
Flags: review?(cdawson) → review+
|
||
Comment 3•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/97caefe4286aa396e34619ea70d5a569d6ce175e
Bug 1468092 - Convert lodash .sum() to native ES6 (#3675)
|
|
||
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
|
|
||
Comment 4•7 years ago
|
||
Many thanks for the PR! :-)
You need to log in
before you can comment on or make changes to this bug.
Description
•