Closed
Bug 1468111
Opened 6 years ago
Closed 6 years ago
Convert lodash .clone() to native ES6 JS
Categories
(Tree Management :: Treeherder: Frontend, enhancement, P3)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evct, Assigned: evct, Mentored)
References
Details
Attachments
(1 file)
Converting all _.clone() (lodash) functions to ES6 JS
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → oss
Assignee | ||
Updated•6 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Updated•6 years ago
|
Priority: -- → P3
Comment 1•6 years ago
|
||
Assignee | ||
Comment 2•6 years ago
|
||
According to the type of collection, I used: - Object: const clone = Object.assign({}, objectToClone); - Array: const clone = arrayToClone.slice(); I hope I didn't make a mistake on the type of different collections to deal with!
Assignee | ||
Updated•6 years ago
|
Attachment #8984760 -
Flags: review?(cdawson)
Assignee | ||
Updated•6 years ago
|
Attachment #8984760 -
Flags: review?(cdawson)
Updated•6 years ago
|
Attachment #8984760 -
Flags: review?(cdawson)
Comment 3•6 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder https://github.com/mozilla/treeherder/commit/d8d144f3d6111eaee93e75998b791d77095c7de1 Bug 1468111 - convert _.clone() usages to ES6 (#3647)
Comment 4•6 years ago
|
||
Comment on attachment 8984760 [details] [review] Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3647 Thanks for the PR!
Attachment #8984760 -
Flags: review?(cdawson) → review+
Updated•6 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•