Closed
Bug 1468161
Opened 7 years ago
Closed 7 years ago
Convert lodash .min() to native ES6 JS
Categories
(Tree Management :: Treeherder: Frontend, defect, P3)
Tree Management
Treeherder: Frontend
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: evct, Assigned: SirR4T, Mentored)
References
Details
Attachments
(1 file)
Converting all _.min() (lodash) functions to Math.min() (ES6 JS)
|
Reporter | |
Updated•7 years ago
|
|
|
Reporter | |
Comment 1•7 years ago
|
||
See bug 1468160.
|
||
Comment 2•7 years ago
|
||
|
Assignee | |
Comment 3•7 years ago
|
||
Needs review.
Used
Math.min.apply(null, arg)
instead of
_.min(arg)
, since only the minimum values were being used in string concatenation. No issue of Date objects here.
|
||
Updated•7 years ago
|
Assignee: oss → sarat.addepalli
|
|
||
Updated•7 years ago
|
Attachment #8996630 -
Flags: review?(cdawson)
|
||
Comment 4•7 years ago
|
||
Commit pushed to master at https://github.com/mozilla/treeherder
https://github.com/mozilla/treeherder/commit/b9fe4ab2c67e58c046a4cc76c433dbc3b9a177f7
Bug 1468161 - Convert _.min to use native ES6 JS (#3860)
|
||
Updated•7 years ago
|
Attachment #8996630 -
Flags: review?(cdawson) → review+
|
|
||
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•