1468164 - Convert lodash .intersection() & _.difference() to native ES6 JS

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement, P3)

Description

[Eliott Vincent [:evct] (GMT+2)]

Converting all _.intersection() & _.difference (lodash) functions to ES6 JS

Comment 1

[Eliott Vincent [:evct] (GMT+2)]

This should do it (I haven't tested it yet):

const e = [2,1];
const f = [2,3];
const intersection = Array.from(new Set(e.filter(x => f.includes(x))));
console.log(intersection);
// [2]

const g = [2,1];
const h = [2,3];
const difference = Array.from(new Set(g.filter(x => !h.includes(x))));
console.log(difference);
// [1]

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3656

Comment 3

[Cameron Dawson [:camd]]

Comment on attachment 8985078 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3656

Left feedback in the PR.

Comment 4

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/5d9b37e0fb0e24a99a64f2f0b0481eea719717e6
Bug 1468164 - convert _.intersection() & _.difference() usages to ES6 (#3656)

Use single lodash import

Comment 5

[Cameron Dawson [:camd]]

Comment on attachment 8985078 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3656

Thanks for the updates!