1468207 - Use the new timer-based available memory tracker for Win32 builds

Status: RESOLVED FIXED

(Core :: Memory Allocator, enhancement)

Description

[Gabriele Svelto [:gsvelto]]

+++ This bug was initially created as a clone of Bug #1459212 +++

Now that we have proven that the new timer-based low-memory detector is working properly (see bug 1451005 comment 52) we should migrate the Win32 build to use it instead of the DLL hooks. This will make the code cleaner and more robust since we don't have to do stuff within a DLL hook.

Comment 1

[Gabriele Svelto [:gsvelto]]

David, I think this is the right move but I wanted to hear your opinion first before going ahead with it.

Comment 2

[(Away)]

Test and measure of course, but in general I support this.

Comment 3

[Gabriele Svelto [:gsvelto]]

Attachment: Bug 1468207 - Use the new timer-based available memory tracker on Win32

Comment 4

[Phabricator Automation]

Comment on attachment 8989835 [details]
Bug 1468207 - Use the new timer-based available memory tracker on Win32

David Major [:dmajor] has approved the revision.

https://phabricator.services.mozilla.com/D1959

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/949281ce6b3d
Use the new timer-based available memory tracker on Win32 r=dmajor

Comment 6

[Eliza Balazs [:ebalazs_]]

Backed out changeset 949281ce6b3d (bug 1468207) for bustage in src/xpcom/base/AvailableMemoryTracker.cpp on a CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=949281ce6b3d4809c1a11440f547afeeff851862&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable&selectedJob=186778050

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=186778050&repo=autoland

Backout: https://hg.mozilla.org/integration/autoland/rev/0d55bc8d79ba184c10aee2b4808d63ebfd04f0f0

Comment 7

[Gabriele Svelto [:gsvelto]]

I had modified the patch after my try run and forgot to run it on try again before landing it. Sorry for the bustage.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/44da9bba96d1
Use the new timer-based available memory tracker on Win32; r=dmajor

Comment 9

[Gabriele Svelto [:gsvelto]]

Everything's green now:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=1cbab2d272b91fdd2a05c4840d60e8f0ca0cf8a8

Comment 10

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/44da9bba96d1