Closed Bug 1468207 Opened 2 years ago Closed Last year

Use the new timer-based available memory tracker for Win32 builds

Categories

(Core :: Memory Allocator, enhancement)

x86
Windows
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla63
Tracking Status
firefox63 --- fixed

People

(Reporter: gsvelto, Assigned: gsvelto)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1459212 +++

Now that we have proven that the new timer-based low-memory detector is working properly (see bug 1451005 comment 52) we should migrate the Win32 build to use it instead of the DLL hooks. This will make the code cleaner and more robust since we don't have to do stuff within a DLL hook.
David, I think this is the right move but I wanted to hear your opinion first before going ahead with it.
Flags: needinfo?(dmajor)
Test and measure of course, but in general I support this.
Flags: needinfo?(dmajor)
Assignee: nobody → gsvelto
Status: NEW → ASSIGNED
Comment on attachment 8989835 [details]
Bug 1468207 - Use the new timer-based available memory tracker on Win32

David Major [:dmajor] has approved the revision.

https://phabricator.services.mozilla.com/D1959
Attachment #8989835 - Flags: review+
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/949281ce6b3d
Use the new timer-based available memory tracker on Win32 r=dmajor
Blocks: 1473821
I had modified the patch after my try run and forgot to run it on try again before landing it. Sorry for the bustage.
Flags: needinfo?(gsvelto)
Pushed by gsvelto@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/44da9bba96d1
Use the new timer-based available memory tracker on Win32; r=dmajor
https://hg.mozilla.org/mozilla-central/rev/44da9bba96d1
Status: ASSIGNED → RESOLVED
Closed: Last year
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.