Closed Bug 1468225 Opened 5 years ago Closed 5 years ago

remove interface function and implementation of nsICertificateDialogs.viewCert

Categories

(Core :: Security: PSM, enhancement, P1)

Product:
Core
Component:
Security: PSM
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla63
Tracking Flags:
Tracking Status
firefox63 --- fixed

People

(Reporter: jcj, Assigned: dipen)

References

(Blocks 1 open bug)

Details

(Whiteboard: [psm-assigned])

Attachments

(1 file)

Bug 1468225 - remove method nsICertificateDialogs.viewCert and its uses. r=keeler,jryans
46 bytes, text/x-phabricator-request
keeler
: review+
Gijs
: review+
Details | Review 
nsICertificateDialogs.viewCert: any uses of this can be converted to directly open the underlying UI treatment:

* browser/base/content/pageinfo/security.js
* mobile/android/components/NSSDialogService.js
* security/manager/pki/resources/content/pippki.js
Whiteboard: [psm-assigned] [psm-contractor] → [psm-backlog]
IIUC, what we want to do here is remove this unnecessary interface/implementation and directly open the dialog as necessary.
Summary: No More Dialogs from nsICertificateDialogs.viewCert → remove interface function and implementation of nsICertificateDialogs.viewCert
- Remove the viewCert method from nsICertificateDialogs
- Remove all associated C++ code
- Directly invoke UI window where it was previous called.
- Update tests

MozReview-Commit-ID: 9b62Go0DjE9
Comment on attachment 9000029 [details]
Bug 1468225 - remove method nsICertificateDialogs.viewCert and its uses. r=keeler,jryans

[:keeler] (use needinfo) has approved the revision.
Attachment #9000029 - Flags: review+
Comment on attachment 9000029 [details]
Bug 1468225 - remove method nsICertificateDialogs.viewCert and its uses. r=keeler,jryans

:Gijs (he/him) has approved the revision.
Attachment #9000029 - Flags: review+
Assignee: nobody → bugzilla
Priority: P3 → P1
Whiteboard: [psm-backlog] → [psm-assigned]
Pushed by rvandermeulen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3dd6ba40f3bf
remove method nsICertificateDialogs.viewCert and its uses. r=Gijs,keeler
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/3dd6ba40f3bf
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox63: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla63
You need to log in before you can comment on or make changes to this bug.