Closed Bug 1468225 Opened 2 years ago Closed 2 years ago
remove interface function and implementation of ns
ICertificate Dialogs .view Cert
nsICertificateDialogs.viewCert: any uses of this can be converted to directly open the underlying UI treatment: * browser/base/content/pageinfo/security.js * mobile/android/components/NSSDialogService.js * security/manager/pki/resources/content/pippki.js
2 years ago
Whiteboard: [psm-assigned] [psm-contractor] → [psm-backlog]
IIUC, what we want to do here is remove this unnecessary interface/implementation and directly open the dialog as necessary.
Summary: No More Dialogs from nsICertificateDialogs.viewCert → remove interface function and implementation of nsICertificateDialogs.viewCert
- Remove the viewCert method from nsICertificateDialogs - Remove all associated C++ code - Directly invoke UI window where it was previous called. - Update tests MozReview-Commit-ID: 9b62Go0DjE9
Comment on attachment 9000029 [details] Bug 1468225 - remove method nsICertificateDialogs.viewCert and its uses. r=keeler,jryans [:keeler] (use needinfo) has approved the revision.
Comment on attachment 9000029 [details] Bug 1468225 - remove method nsICertificateDialogs.viewCert and its uses. r=keeler,jryans :Gijs (he/him) has approved the revision.
Assignee: nobody → bugzilla
Priority: P3 → P1
Whiteboard: [psm-backlog] → [psm-assigned]
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/3dd6ba40f3bf remove method nsICertificateDialogs.viewCert and its uses. r=Gijs,keeler
You need to log in before you can comment on or make changes to this bug.