1468225 - remove interface function and implementation of nsICertificateDialogs.viewCert

Status: RESOLVED FIXED

(Core :: Security: PSM, enhancement, P1)

Description

[J.C. Jones [:jcj] (he/they)]

nsICertificateDialogs.viewCert: any uses of this can be converted to directly open the underlying UI treatment:

* browser/base/content/pageinfo/security.js
* mobile/android/components/NSSDialogService.js
* security/manager/pki/resources/content/pippki.js

Comment 1

[Dana Keeler (she/her) [:keeler]]

IIUC, what we want to do here is remove this unnecessary interface/implementation and directly open the dialog as necessary.

Comment 2

[Dipen Patel [:dipen]]

Attachment: Bug 1468225 - remove method nsICertificateDialogs.viewCert and its uses. r=keeler,jryans

- Remove the viewCert method from nsICertificateDialogs
- Remove all associated C++ code
- Directly invoke UI window where it was previous called.
- Update tests

MozReview-Commit-ID: 9b62Go0DjE9

Comment 3

[Dana Keeler (she/her) [:keeler]]

Comment on attachment 9000029 [details]
Bug 1468225 - remove method nsICertificateDialogs.viewCert and its uses. r=keeler,jryans

[:keeler] (use needinfo) has approved the revision.

Comment 4

[:Gijs (he/him)]

Comment on attachment 9000029 [details]
Bug 1468225 - remove method nsICertificateDialogs.viewCert and its uses. r=keeler,jryans

:Gijs (he/him) has approved the revision.

Comment 5

[Dipen Patel [:dipen]]

Try run: https://treeherder.mozilla.org/#/jobs?repo=try&revision=1a1aab164a74325178378da91daa4a54203c073f

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3dd6ba40f3bf
remove method nsICertificateDialogs.viewCert and its uses. r=Gijs,keeler

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/3dd6ba40f3bf