Closed Bug 1468230 Opened 6 years ago Closed 4 years ago

[meta] Complete removal of nsIBadCertListener2

Categories

(Core :: Security: PSM, enhancement, P3)

Product:
Core
Component:
Security: PSM
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Future

People

(Reporter: jcj, Unassigned)

References

Details

(Keywords: meta, Whiteboard: [psm-tracking]) 

Android: 

SSLExceptions.jsm - used in order to get a handle on the site’s certificate in the certificate error page. We either already have that information (docshell.failedChannel… like browser.js does it) or we can do it how exceptionDialog.js does: https://searchfox.org/mozilla-central/rev/00dd116638001772fe354b081353b73f1cad405d/security/manager/pki/resources/content/exceptionDialog.js#75

Tests (Bug 846581):
https://searchfox.org/mozilla-central/rev/00dd116638001772fe354b081353b73f1cad405d/dom/push/test/xpcshell/head-http2.js#36
https://searchfox.org/mozilla-central/rev/00dd116638001772fe354b081353b73f1cad405d/netwerk/test/unit/test_http2.js#1196
https://searchfox.org/mozilla-central/rev/00dd116638001772fe354b081353b73f1cad405d/toolkit/mozapps/extensions/test/browser/head.js#626
These can all do what exceptionDialog.js does
https://searchfox.org/mozilla-central/rev/00dd116638001772fe354b081353b73f1cad405d/services/common/rest.js#485 - this doesn’t even do anything. It can just be removed.

When these are all removed, we can remove nsIBadCertListener2.idl and the call site in security/manager/ssl/SSLServerCertVerification.cpp
Assignee: bugzilla → nobody
Status: ASSIGNED → NEW
Summary: Complete removal of nsIBadCertListener2 → [meta] Complete removal of nsIBadCertListener2
Whiteboard: [psm-assigned] [psm-contractor] → [psm-tracking]
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.