1468268 - Remove & simplify unnecessary CSS in contain:paint reftests

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P3)

Description

[Yusuf Sermet [:yusuf]]

This bug is for refactoring the tests for contain:paint as detailed in:

https://bugzilla.mozilla.org/show_bug.cgi?id=1170781#c60

Comment 1

[Yusuf Sermet [:yusuf]]

Attachment: Bug 1468268 - Refactor test cases for contain:paint.

Review commit: https://reviewboard.mozilla.org/r/250680/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/250680/

Comment 2

[Yusuf Sermet [:yusuf]]

Please see below for the details of this commit:

https://bugzilla.mozilla.org/show_bug.cgi?id=1170781#c64

Comment 3

[Daniel Holbert [:dholbert]]

Comment on attachment 8984906 [details]
Bug 1468268 - Refactor test cases for contain:paint.

https://reviewboard.mozilla.org/r/250680/#review257186

Stealing review -- this looks good to me! r+, assuming it looks good on Try (you can do a reftests-only run there -- no need to run other suites, since reftests are the only thing that you're changing here.)

::: commit-message-67725:1
(Diff revision 1)
> +Bug 1468268 - Refactor test cases for contain:paint. r=gerald

Nit: The word "refactor" is a bit vague & sounds more destabilizing than what's actually/mostly going on here. It'd be clearer (RE describing your changes) to reword this to something like:

  "Remove & simplify unnecessary CSS in contain:paint reftests"

Comment 4

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Thank you Daniel.

(It dropped off my radar; ping me next time, if I don't review within 1 day.)

Comment 5

[Yusuf Sermet [:yusuf]]

Attachment: Bug 1468268 - Remove & simplify unnecessary CSS in contain:paint reftests.

Review commit: https://reviewboard.mozilla.org/r/251048/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/251048/

Comment 6

[Yusuf Sermet [:yusuf]]

(In reply to Daniel Holbert [:dholbert] from comment #3)
> assuming it looks good on Try
> (you can do a reftests-only run there -- no need to run other suites, since
> reftests are the only thing that you're changing here.)

Thanks! Commit is updated and reftests-only try run is in process.

Comment 7

[Daniel Holbert [:dholbert]]

Comment on attachment 8985474 [details]
Bug 1468268 - Remove & simplify unnecessary CSS in contain:paint reftests.

https://reviewboard.mozilla.org/r/251048/#review257326

Looks great, thanks!

Comment 8

[Daniel Holbert [:dholbert]]

Looks like Try run completed, and I think you're good to add "checkin-needed" if you're ready for this to land.

(The orange "macosx64-ccov debug" test runs look unrelated to your changes, so don't worry about those.  The logs all end with "Aborting task - max run time exceeded!", which I suspect is just because these test jobs aren't ready for prime time. I don't see these on the mozilla-central treeherder, so they're probably hidden/disabled there, presumably due to these timeouts. I'm guessing code-coverage-checking adds a lot of overhead and causes us to run over the allowed time, or something.)

Comment 9

[Yusuf Sermet [:yusuf]]

(In reply to Daniel Holbert [:dholbert] from comment #8)
> Looks like Try run completed, and I think you're good to add
> "checkin-needed" if you're ready for this to land.
> 
> (The orange "macosx64-ccov debug" test runs look unrelated to your changes,
> so don't worry about those.  The logs all end with "Aborting task - max run
> time exceeded!", which I suspect is just because these test jobs aren't
> ready for prime time. I don't see these on the mozilla-central treeherder,
> so they're probably hidden/disabled there, presumably due to these timeouts.
> I'm guessing code-coverage-checking adds a lot of overhead and causes us to
> run over the allowed time, or something.)

Done, thanks!

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a22e0c8e52e1
Remove & simplify unnecessary CSS in contain:paint reftests. r=dholbert

Comment 11

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/a22e0c8e52e1

Comment 12

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Merged to web-platform-tests in https://github.com/web-platform-tests/wpt/pull/11628 .