1468305 - Convert lodash .chunk() to native ES6 JS

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Frontend, enhancement, P3)

Description

[Eliott Vincent [:evct] (GMT+2)]

Converting all _.chunk() (lodash) functions to ES6 JS

Comment 1

[Eliott Vincent [:evct] (GMT+2)]

I wrote this piece of code, it seems to do the job:

const myArray = ['a', 'b', 'c', 'd'];

const chunked1 = myArray.reduce((acc, val, idx, arr, chunkSize = 2) =>
    !(idx % chunkSize) ? acc.concat([arr.slice(idx, idx + chunkSize)]) : acc, 
    []);
console.log(chunked1);
// => [['a', 'b'], ['c', 'd']]

const chunked2 = myArray.reduce((acc, val, idx, arr, chunkSize = 3) =>
    !(idx % chunkSize) ? acc.concat([arr.slice(idx, idx + chunkSize)]) : acc, 
    []);
console.log(chunked2);
// => [['a', 'b', 'c'], ['d']]

I will implement this within the week (unless there are remarks), along with the other bugs I've opened lately.

Comment 2

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3657

Comment 3

[Cameron Dawson [:camd]]

Comment on attachment 8985082 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3657

Let's just import the ``chunk`` function from ``lodash`` directly and continue to use it.  I think it'll be clearer in this case than doing a complex ``reduce``.  

The import should be:  import chunk from 'lodash/chunk';

Thanks!

Comment 4

[Cameron Dawson [:camd]]

Still awaiting code updates on this PR.

Comment 5

[Cameron Dawson [:camd]]

Oops, I just noticed you can re-assign to me when you've made your updates.  I'll let you do that instead of n-i'ing myself.  :)

Comment 6

[Eliott Vincent [:evct] (GMT+2)]

Comment on attachment 8985082 [details] [review]
Link to GitHub pull-request: https://github.com/mozilla/treeherder/pull/3657

Request changes done.

Comment 7

[Treeherder GitHub Bugbot]

Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/8847c733736fe8a1e19e5ac65784f9ab21216781
Bug 1468305 - convert _.chunk() usages to ES6 (#3657)

Comment 8

[Cameron Dawson [:camd]]

Thanks for the PR!