Closed Bug 1468308 Opened 6 years ago Closed 6 years ago

Convert lodash .invert() to native ES6 JS

Categories

(Tree Management :: Treeherder: Frontend, defect, P3)

Product:
Tree Management
Component:
Treeherder: Frontend
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1476652

People

(Reporter: evct, Assigned: evct, Mentored)

References

Details

Converting all _.invert() (lodash) functions to ES6 JS
Assignee: nobody → oss
Blocks: 1466494
Status: NEW → ASSIGNED
Priority: -- → P3
I haven't thought about this piece yet, but I've already had to replace _.invert() with ES6 on a personal project. It should be even simpler with the spread operator!
Hi Elliot - hope you are well. Soundharya just filed a bug that I've duped to this one. Are you still working on this, or is it up for grabs? :-)
Hello Ed! I was out of office for the last three weeks and just got back. I will continue to work on the remaining ES6 bugs I opened, including this one. Thanks
Can be marked as duplicate to https://bugzilla.mozilla.org/show_bug.cgi?id=1476652, as _.invert is being converted there.
Great work on 1476652 Sarat! Sorry for letting it down, I was nearly ready to submit my changes but you came up with a better solution than mine ;)
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → DUPLICATE
thanks Eliott! wasn't sure if I was stepping on anyone's toes, though, because 1466494 had a lot of child issues, and it took me a while to filter out ones that were done, and ones that hadn't had a PR raised yet.
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/44032ff5185049ebf9ccb412c3b17067db6d1d2d
Bug 1476652 1468308 1476243 - _.omit, _.invert, _.mapValues to ES6 (#3859)

Since _.omit, _.invert, and _.mapValues are all used only once in
the treeherder codebase, for building a map of buildbot buildername
to taskcluster tasklabel, this commit fixes all the three at once
instead of three different bugs.

Related Bugs:
- https://bugzilla.mozilla.org/show_bug.cgi?id=1476652
- https://bugzilla.mozilla.org/show_bug.cgi?id=1468308
- https://bugzilla.mozilla.org/show_bug.cgi?id=1476243
You need to log in before you can comment on or make changes to this bug.