1468328 - Make lcov_rewriter.py and its dependencies Python 3 compatible for importing as module

Status: RESOLVED FIXED

(Testing :: Code Coverage, defect)

Description

[assiya.khuzyakhmetova]

User Agent: Mozilla/5.0 (X11; Ubuntu; Linux x86_64; rv:60.0) Gecko/20100101 Firefox/60.0
Build ID: 20180517113820

Steps to reproduce:

Downloaded the artifact from https://queue.taskcluster.net/v1/task/etuu0o82Tpy1L6yhaNhkWA/runs/0/artifacts/public/build/target.common.tests.zip, tried to import function from the lcov_rewriter.py module in Python 3.6 project. 


Actual results:

Import Error saying that urlparse library is not found because it is renamed from Python 3.4 to be urllib.parse.


Expected results:

The function should have been imported.

Comment 1

[assiya.khuzyakhmetova]

Attachment: Bug 1468328 - Make import statement Python3 compatible.

Review commit: https://reviewboard.mozilla.org/r/250998/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/250998/

Comment 2

[Marco Castelluccio [:marco]]

Comment on attachment 8985361 [details]
Bug 1468328 - Make import statement Python3 compatible.

https://reviewboard.mozilla.org/r/250998/#review257406

Looks good, thanks! Just a minor nit for the commit message.

::: commit-message-0344a:1
(Diff revision 1)
> +Bug 1468328  - Made import statement Python3 compatible. r=marco

Can you change the commit message to:
"Bug 1468328 - Make import statement Python 3 compatible. r=marco"

(1 space between the bug number and "-" and the verb  in the present tense)

Comment 3

[assiya.khuzyakhmetova]

Comment on attachment 8985361 [details]
Bug 1468328 - Make import statement Python3 compatible.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/250998/diff/1-2/

Comment 4

[Marco Castelluccio [:marco]]

Comment on attachment 8985361 [details]
Bug 1468328 - Make import statement Python3 compatible.

https://reviewboard.mozilla.org/r/250998/#review257440

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/dc997a4e045e
Make import statement Python3 compatible. r=marco

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/dc997a4e045e

Comment 7

[assiya.khuzyakhmetova]

Attachment: Bug 1468328 - Make other codecoverage import statements Python3 compatible.

Review commit: https://reviewboard.mozilla.org/r/251198/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/251198/

Comment 8

[Marco Castelluccio [:marco]]

Comment on attachment 8985662 [details]
Bug 1468328 - Make other codecoverage import statements Python3 compatible.

https://reviewboard.mozilla.org/r/251198/#review257522

Are you sure these are the last instances? Does importing the module in Python 3 work now?

::: commit-message-77d19:1
(Diff revision 1)
> +Bug 1468328 - Make import statements Python3 compatible. r=marco

"Bug 1468328 - Make other codecoverage import statements Python3 compatible. r=marco"

Comment 9

[assiya.khuzyakhmetova]

(In reply to Marco Castelluccio [:marco] from comment #8)
> Comment on attachment 8985662 [details]
> Bug 1468328 - Make import statements Python3 compatible.
> 
> https://reviewboard.mozilla.org/r/251198/#review257522
> 
> Are you sure these are the last instances? Does importing the module in
> Python 3 work now?
> 
> ::: commit-message-77d19:1
> (Diff revision 1)
> > +Bug 1468328 - Make import statements Python3 compatible. r=marco
> 
> "Bug 1468328 - Make other codecoverage import statements Python3 compatible.
> r=marco"

Yep, I was able to use it with these changes in Python 3.6 crawler.

Comment 10

[assiya.khuzyakhmetova]

Comment on attachment 8985662 [details]
Bug 1468328 - Make other codecoverage import statements Python3 compatible.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/251198/diff/1-2/

Comment 11

[Marco Castelluccio [:marco]]

Comment on attachment 8985662 [details]
Bug 1468328 - Make other codecoverage import statements Python3 compatible.

https://reviewboard.mozilla.org/r/251198/#review257526

Comment 12

[Mozilla Autoland]

We're sorry - something has gone wrong while rewriting or rebasing your commits. The commits being pushed no longer match what was requested. Please file a bug.

Comment 13

[Mozilla Autoland]

We're sorry - something has gone wrong while rewriting or rebasing your commits. The commits being pushed no longer match what was requested. Please file a bug.

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/44827df784b2
Make other codecoverage import statements Python3 compatible. r=marco

Comment 15

[Marco Castelluccio [:marco]]

Comment on attachment 8985662 [details]
Bug 1468328 - Make other codecoverage import statements Python3 compatible.

https://reviewboard.mozilla.org/r/251198/#review257584

::: python/mozbuild/mozpack/chrome/manifest.py:11
(Diff revision 2)
>  
>  import re
>  import os
> -from urlparse import urlparse
> +
> +try:
> +    import urlparse

I hadn't noticed, but there's actually a problem here.

You replaced `from urlparse import urlparse` with `import urlparse`.

Comment 16

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/151566903ceb
Backed out changeset 44827df784b2 for bustages on builds/worker/workspace/build/src/python/mozbuild/mozpack/chrome/manifest.py on a CLOSED TREE

Comment 17

[Noemi Erli[:noemi_erli]]

Backed out changeset 44827df784b2 (bug 1468328) for bustages on builds/worker/workspace/build/src/python/mozbuild/mozpack/chrome/manifest.py on a CLOSED TREE

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=44827df784b29011bd833cecdf23835db2e18b03&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&selectedJob=183395679

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=183395707&repo=mozilla-inbound&lineNumber=1466

Backout: https://hg.mozilla.org/integration/mozilla-inbound/rev/151566903cebc527b99469566d7fcbf22562d239

Comment 18

[assiya.khuzyakhmetova]

Attachment: Bug 1468328 - Make other codecoverage import statements Python3 compatible.

Review commit: https://reviewboard.mozilla.org/r/251288/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/251288/

Comment 19

[Marco Castelluccio [:marco]]

Comment on attachment 8985755 [details]
Bug 1468328 - Make other codecoverage import statements Python3 compatible.

https://reviewboard.mozilla.org/r/251288/#review257618

Looks good, but could you squash the last two commits together?

Comment 20

[assiya.khuzyakhmetova]

Comment on attachment 8985755 [details]
Bug 1468328 - Make other codecoverage import statements Python3 compatible.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/251288/diff/1-2/

Comment 21

[Marco Castelluccio [:marco]]

Comment on attachment 8985755 [details]
Bug 1468328 - Make other codecoverage import statements Python3 compatible.

https://reviewboard.mozilla.org/r/251288/#review257620

Comment 22

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3ee42b865a76
Make other codecoverage import statements Python3 compatible. r=marco

Comment 23

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/3ee42b865a76