1468349 - Web Authentication - Support FreeBSD

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, enhancement, P1)

Description

[J.C. Jones [:jcj] (he/they)]

This is to uplift FreeBSD support from u2f-hid-rs.

Comment 1

[Phabricator Automation]

Attachment: Bug 1468349 - Web Authentication - Add FreeBSD Support r=jcj

Upstream PR: https://github.com/jcjones/u2f-hid-rs/pull/62

* Extract hidproto module from linux::hidraw
Make the protocol parts independent of Linux code, in preparation for
adding FreeBSD support.

* Add FreeBSD (uhid + devd) support
Tested with a YubiKey 4.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/80190d88549c
Web Authentication - Add FreeBSD Support

Comment 3

[J.C. Jones [:jcj] (he/they)]

Note: While Lando stripped the r=jcj off, this was reviewed by me and ttaubert upstream.

Comment 4

[Andreea Pavel [:apavel]]

Backed out for failing build bustages

Push that caused the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=80190d88549cf49b79fea1d350e65d8828f33810

Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=182933085&repo=autoland&lineNumber=9360

Backout: https://hg.mozilla.org/integration/autoland/rev/a6c7994970b7b0a79dc7a0668bfff9f4597bb640

Comment 5

[J.C. Jones [:jcj] (he/they)]

Apologies for the false-start on uplifting u2f-hid-rs (w/o ttaubert's guidance, who has been handling this before).

That said, there's a problem with `nom`, a dependency of `devd-rs` used for FreeBSD:

    $ mach vendor rust
     0:23.31 The following files exceed the filesize limit of 102400:

    third_party/rust/nom-1.2.4/src/macros.rs

    Please find a way to reduce the sizes of these files or talk to a build
    peer about the particular large files you are adding.

    The changes from `mach vendor rust` will NOT be added to version control.

So I need to reach out to the build team and find out if we can let the 120768-byte nom-for-macos file in. It will be unused currently, as the only user of nom will be freebsd.

Comment 6

[J.C. Jones [:jcj] (he/they)]

Attachment: Bug 1468349 - Web Authentication - Add FreeBSD Support

Summary:
Upstream PR: https://github.com/jcjones/u2f-hid-rs/pull/62

* Extract hidproto module from linux::hidraw
Make the protocol parts independent of Linux code, in preparation for
adding FreeBSD support.

* Add FreeBSD (uhid + devd) support
Tested with a YubiKey 4.

Tags: #secure-revision

Bug #: 1468349

Differential Revision: https://phabricator.services.mozilla.com/D1636

Review commit: https://reviewboard.mozilla.org/r/250764/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/250764/

Comment 7

[J.C. Jones [:jcj] (he/they)]

Attachment: Bug 1468349 - Vendor in new freebsd deps for u2f-hid-rs

Review commit: https://reviewboard.mozilla.org/r/250766/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/250766/

Comment 8

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 8985037 [details]
Bug 1468349 - Web Authentication - Add FreeBSD Support

https://reviewboard.mozilla.org/r/250764/#review256988

Reviewed upstream.

Comment 9

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 8985038 [details]
Bug 1468349 - Vendor in new freebsd deps for u2f-hid-rs

https://reviewboard.mozilla.org/r/250766/#review257062

Note: compare to https://hg.mozilla.org/try/rev/aefcd2a3625860e2228aa8b12068eae1d12fdf13

Comment 10

[Mark Goodwin [:mgoodwin]]

Comment on attachment 8985038 [details]
Bug 1468349 - Vendor in new freebsd deps for u2f-hid-rs

https://reviewboard.mozilla.org/r/250766/#review257226

Comment 11

[Mozilla Autoland]

We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 39f22b0351c2893b26cb7c04dcc879a093bfa78a -d 35b28db3b16e: rebasing 468136:39f22b0351c2 "Bug 1468349 - Web Authentication - Add FreeBSD Support r=jcj"
merging dom/webauthn/u2f-hid-rs/Cargo.toml
merging dom/webauthn/u2f-hid-rs/README.md
merging dom/webauthn/u2f-hid-rs/src/lib.rs
merging dom/webauthn/u2f-hid-rs/src/linux/hidraw.rs
merging dom/webauthn/u2f-hid-rs/src/macos/iokit.rs
merging dom/webauthn/u2f-hid-rs/src/macos/monitor.rs
merging dom/webauthn/u2f-hid-rs/src/macos/transaction.rs
merging dom/webauthn/u2f-hid-rs/src/statemachine.rs
merging dom/webauthn/u2f-hid-rs/src/util.rs
rebasing 468137:49d76d6600b9 "Bug 1468349 - Vendor in new freebsd deps for u2f-hid-rs r=mgoodwin" (tip)
merging Cargo.lock
warning: conflicts while merging Cargo.lock! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)

Comment 12

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 8985037 [details]
Bug 1468349 - Web Authentication - Add FreeBSD Support

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/250764/diff/1-2/

Comment 13

[J.C. Jones [:jcj] (he/they)]

Comment on attachment 8985038 [details]
Bug 1468349 - Vendor in new freebsd deps for u2f-hid-rs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/250766/diff/1-2/

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8ebf45b0854a
Web Authentication - Add FreeBSD Support r=jcj
https://hg.mozilla.org/integration/autoland/rev/ee93e9e7bcfd
Vendor in new freebsd deps for u2f-hid-rs r=mgoodwin

Comment 15

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/8ebf45b0854a
https://hg.mozilla.org/mozilla-central/rev/ee93e9e7bcfd

Comment 16

[J.C. Jones [:jcj] (he/they)]

FreeBSD support for WebAuthn might be worthy of a relnote?

Comment 17

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Added to Firefox 62 release notes.