1468403 - Crash in java.lang.IllegalStateException: Current session is open at org.mozilla.geckoview.GeckoView.setSession(GeckoView.java)

Status: RESOLVED FIXED

(GeckoView :: General, defect, P2)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is
report bp-0efe5151-085f-486a-a17c-0c3700180611.
=============================================================

java.lang.IllegalStateException: Current session is open
	at org.mozilla.geckoview.GeckoView.setSession(GeckoView.java:246)
	at org.mozilla.geckoview.GeckoView.setSession(GeckoView.java:233)
	at org.mozilla.focus.web.WebViewProvider$GeckoWebView$1.onCrash(WebViewProvider.java:303)
	at org.mozilla.geckoview.GeckoSession$1.handleMessage(GeckoSession.java:125)
	at org.mozilla.geckoview.GeckoSession$1.handleMessage(GeckoSession.java:116)
	at org.mozilla.geckoview.GeckoSessionHandler.handleMessage(GeckoSessionHandler.java:79)
	at org.mozilla.gecko.EventDispatcher$2.run(EventDispatcher.java:344)
	at android.os.Handler.handleCallback(Handler.java:751)
	at android.os.Handler.dispatchMessage(Handler.java:95)
	at android.os.Looper.loop(Looper.java:154)
	at android.app.ActivityThread.main(ActivityThread.java:6165)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:888)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:778)

=============================================================

There are 3 crashes (from 1 installation) in nightly 62 with buildid 20180611100107. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1465480.

[1] https://hg.mozilla.org/mozilla-central/rev?node=d9d0a8abad40

Comment 1

[James Willcox (:snorp) ([e-mail]) (he/him)]

This is a Focus bug. Not sure how it ended up getting reported here.

Emily, are you seeing Sentry reports as well?

WRT the crash, if you are calling open() on the crashed session, you should not call GeckoView.setSession() afterwards.

Comment 2

[Emily Kager [:ekager]]

I can't get the crashed session to reopen at all. I am currently closing the current session, creating a new session, assigning delegates, setting the new session, opening the new session, and loading the current URL. This is the only series of calls I can get to work to load any page after onCrash.

Comment 3

[Mike Taylor [:miketaylr]]

(pretty low volume, marking as fix-optional for 62)

Comment 4

[Chris Peterson [:cpeterson]]

See also "IllegalStateException: Current session is open" bug 1435500 fixed in Fennec 59.

Comment 5

[Jim Mathies [:jimm]]

Susheel, we're trying to figure out where focus front end bugs should be filed. Can you assist in moving this from android to an appropriate product/component?

Comment 6

[:sdaswani]

Emily do we have a bug in Focus Android for this?

Jim, Focus front end should be filed here: https://github.com/mozilla-mobile/focus-android/issues

Comment 7

[Emily Kager [:ekager]]

I think I fixed this issue already and turned off these crashes for you all. Feel free to close and not refile.

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

marking as fixed as per comment #7