1468426 - Change LayerManagerData::mDisplayItems to a vector instead of hashtable

Status: RESOLVED FIXED

(Core :: Web Painting, enhancement)

Description

[Jamie Nicol [:jnicol]]

This should improve cache locality and help speed up layer building.

2.7% win on displaylist_mutate.

Comment 1

[Jamie Nicol [:jnicol]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=e2cd6fa99c70c8bde5f2a64fed1579c3d3d77af0

https://treeherder.mozilla.org/perf.html#/compare?originalProject=mozilla-central&newProject=try&newRevision=e2cd6fa99c70c8bde5f2a64fed1579c3d3d77af0&framework=1&showOnlyImportant=1&selectedTimeRange=172800

Comment 2

[Jamie Nicol [:jnicol]]

Attachment: Bug 1468426 - Change LayerManagerData::mDisplayItems to a vector instead of hashtable.

This should improve cache locality and help speed up layer building.

Review commit: https://reviewboard.mozilla.org/r/250822/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/250822/

Comment 3

[Matt Woodrow (:mattwoodrow)]

Comment on attachment 8985104 [details]
Bug 1468426 - Change LayerManagerData::mDisplayItems to a vector instead of hashtable.

https://reviewboard.mozilla.org/r/250822/#review257078

Comment 4

[Jamie Nicol [:jnicol]]

Comment on attachment 8985104 [details]
Bug 1468426 - Change LayerManagerData::mDisplayItems to a vector instead of hashtable.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/250822/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b076959d6353
Change LayerManagerData::mDisplayItems to a vector instead of hashtable. r=mattwoodrow

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/b076959d6353