Closed Bug 1468529 Opened 2 years ago Closed 2 years ago

Remove "emacs" platformHTMLBindings.xml

Categories

(Core :: XBL, task)

task
Not set

Tracking

()

RESOLVED INVALID
Tracking Status
firefox62 --- affected

People

(Reporter: timdream, Assigned: timdream)

References

Details

platformHTMLBindings.xml hosts the platform-specific editor key bindings.

We switch between platforms at

https://searchfox.org/mozilla-central/rev/d544b118e2642287/dom/xbl/builtin/moz.build

but all of the supported platforms already have their own bindings.

A little investigation in searchfox shows that the build recipe was converted from

https://searchfox.org/mozilla-central/rev/8c137ecae2bb9fa84637358a66acd4e4e065f4f5/content/xbl/builtin/Makefile.in

and annotation shows "emacs" (renamed from "unix" in bug 578718) was indeed used as a fallback as we add platform-specific bindings since the 2000s.

We would need to remove it before working on bug 1419091 because the proposed replacement of platformHTMLBindings.xml there will be no place to put this fallback binding.

I intend to use this bug to do a simple removal and don't load any platformHTMLBindings.xml on unsupported platforms.
This might not be needed anymore with the new approach in bug 1419091 comment 15. I'll reopen if this is not the case.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → INVALID
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.