1468532 - Prevent chatty from dropping logcat messages (packet.net)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, enhancement)

Description

[Geoff Brown [:gbrown]]

+++ This bug was initially created as a clone of Bug #1360920 +++

:bc noticed that chatty is dropping messages from logcat during tests on packet.net and reminded me that...


gbrown noticed in bug 1360908 comment 2 that chatty is dropping messages from logcat. bug 1360908 comment 3 has some pointers:

http://stackoverflow.com/questions/34587273/android-logcat-logs-chatty-module-line-expire-message

has a suggestion

adb logcat -P ""

https://developer.android.com/studio/command-line/logcat.html has more information on setting the white and black lists for messages.


We solved this in autophone earlier. Should we solve this more generally in adb.py, or specifically for packet.net in mozharness, or something like that?

Comment 1

[Bob Clary [:bc] (inactive)]

I would say adb.py/adb_android.py is the right place so that we don't keep hitting this elsewhere. From that stackoverflow link, we can choose:

adb logcat -P ""

or
setprop ro.logd.filter disable
setprop persist.logd.filter disable 

Perhaps adb logcat -P "" is best. We could do this during the initializer for the class.

Comment 2

[Geoff Brown [:gbrown]]

adb logcat -P "" fails on the Android 4.3 emulator:

adb logcat -P ""
unknown option -- PUnrecognized Option
Usage: logcat [options] [filterspecs]
options include:
  -s              Set default filter to silent.
                  Like specifying filterspec '*:s'
  -f <filename>   Log to file. Default to stdout
  -r [<kbytes>]   Rotate log every kbytes. (16 if unspecified). Requires -f
  -n <count>      Sets max number of rotated logs to <count>, default 4
  -v <format>     Sets the log print format, where <format> is one of:

                  brief process tag thread raw time threadtime long

  -c              clear (flush) the entire log and exit
  -d              dump the log and then exit (don't block)
  -t <count>      print only the most recent <count> lines (implies -d)
  -g              get the size of the log's ring buffer and exit
  -b <buffer>     Request alternate ring buffer, 'main', 'system', 'radio'
                  or 'events'. Multiple -b parameters are allowed and the
                  results are interleaved. The default is -b main -b system.
  -B              output the log in binary
filterspecs are a series of 
  <tag>[:priority]

where <tag> is a log component tag (or * for all) and priority is:
  V    Verbose
  D    Debug
  I    Info
  W    Warn
  E    Error
  F    Fatal
  S    Silent (supress all output)

'*' means '*:d' and <tag> by itself means <tag>:v

If not specified on the commandline, filterspec is set from ANDROID_LOG_TAGS.
If no filterspec is found, filter defaults to '*:I'

If not specified with -v, format is set from ANDROID_PRINTF_LOG
or defaults to "brief"


I think that's fine: We can ignore the error (log and continue); I've never seen chatty on Android of this era.

Comment 3

[Geoff Brown [:gbrown]]

Attachment: disable chatty with 'adb logcat -P ""' in ADBDevice init

Comment 4

[Bob Clary [:bc] (inactive)]

Comment on attachment 8985557 [details] [diff] [review]
disable chatty with 'adb logcat -P ""' in ADBDevice init

Review of attachment 8985557 [details] [diff] [review]:
-----------------------------------------------------------------

lgtm.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ff4c7fc41c86
Disable chatty during Android tests; r=bc

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/ff4c7fc41c86